[PATCH v4 02/13] binman: qcom: Add type definitions for Qualcomm binaries

[Simon Glass]

Hi Varadarajan,

On Thu, 4 Jun 2026 at 03:32, Varadarajan Narayanan
<varadarajan.narayanan at oss.qualcomm.com> wrote:
>
> Add type definitions for Qualcomm's
>
>         appsbl  -> APPS Boot Loader (U-Boot)
>         config  -> Board/DDR related configuration
>         lib     -> Library of proprietary routines
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan at oss.qualcomm.com>
> ---
>  tools/binman/etype/qcom_appsbl.py | 18 ++++++++++++++++++
>  tools/binman/etype/qcom_config.py | 21 +++++++++++++++++++++
>  tools/binman/etype/qcom_lib.py    | 21 +++++++++++++++++++++
>  3 files changed, 60 insertions(+)
>  create mode 100644 tools/binman/etype/qcom_appsbl.py
>  create mode 100644 tools/binman/etype/qcom_config.py
>  create mode 100644 tools/binman/etype/qcom_lib.py
>
> diff --git a/tools/binman/etype/qcom_appsbl.py b/tools/binman/etype/qcom_appsbl.py
> new file mode 100644
> index 00000000000..e308ebd2fca
> --- /dev/null
> +++ b/tools/binman/etype/qcom_appsbl.py
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> +#
> +# Entry-type module for U-Boot MBN image
> +#
> +
> +from binman.etype.blob_named_by_arg import Entry_blob_named_by_arg
> +
> +class Entry_qcom_appsbl(Entry_blob_named_by_arg):
> +    """U-Boot mbn image
> +
> +    Properties / Entry arguments:
> +        - filename: Filename of u-boot MBN (default 'u-boot.mbn')

U-Boot (not u-boot)

> +
> +    This is the U-Boot MBN image.

It is good to have this etype, but please document it properly. We
need to know what MBN stands for, along with a link to the spec, etc.
Also please describe its role in booting.

Please do the same for the others below too.

> +    """
> +    def __init__(self, section, etype, node):
> +        super().__init__(section, etype, node, 'qcom-appsbl')
> diff --git a/tools/binman/etype/qcom_config.py b/tools/binman/etype/qcom_config.py
> new file mode 100644
> index 00000000000..a1787c97b34
> --- /dev/null
> +++ b/tools/binman/etype/qcom_config.py
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> +#
> +# Entry-type module for QC Config ELF
> +#
> +
> +from binman.entry import Entry
> +from binman.etype.blob_named_by_arg import Entry_blob_named_by_arg
> +
> +class Entry_qcom_config(Entry_blob_named_by_arg):
> +    """QC Config ELF

Does QC Config mean Qualcomm Config? Is this a configuration file? If
so, why is it in elf format?

> +
> +    Properties / Entry arguments:
> +        - qcom-config-path: Filename of QC Config ELF (typically 'qcconfig.elf')
> +
> +    This will be part of the Qualcomm SPL based bootloader image
> +
> +    """
> +    def __init__(self, section, etype, node):
> +        super().__init__(section, etype, node, 'qcom-config')
> +        self.external = True
> diff --git a/tools/binman/etype/qcom_lib.py b/tools/binman/etype/qcom_lib.py
> new file mode 100644
> index 00000000000..ca7666fe6e6
> --- /dev/null
> +++ b/tools/binman/etype/qcom_lib.py
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> +#
> +# Entry-type module for QC LIB ELF
> +#
> +
> +from binman.entry import Entry
> +from binman.etype.blob_named_by_arg import Entry_blob_named_by_arg
> +
> +class Entry_qcom_lib(Entry_blob_named_by_arg):
> +    """QC LIB ELF
> +
> +    Properties / Entry arguments:
> +        - qcom-lib-path: Filename of QC LIB ELF (typically 'QCLib.elf')
> +
> +    This will be part of the Qualcomm SPL based bootloader image
> +
> +    """
> +    def __init__(self, section, etype, node):
> +        super().__init__(section, etype, node, 'qcom-lib')
> +        self.external = True
> --
> 2.34.1
>

Regards,
Simon