[PATCH v2] xyz-modem: Select CRC16

Daniel Palmer daniel at thingy.jp
Wed Jun 10 10:39:19 CEST 2026


Hi Quentin, Tom

On Mon, 8 Jun 2026 at 23:22, Quentin Schulz <quentin.schulz at cherry.de> wrote:
> Also, lib/Makefile has
>
> obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16-ccitt.o
>
> which is.... odd? Shouldn't this handle the case of "missing" SPL_CRC16
> dependency?

I didn't see this. So it seems like for now just adding
CONFIG_YMODEM_SUPPORT, making that select CONFIG_CRC16 and the
Makefile tweak would be enough for now.

Would that be acceptable for now? It seems like the xyzmodem thing
needs a bit of refactoring etc. I actually have an almost entirely
rewritten version of it somewhere that I wrote because of the issues
in the current version. I'd prefer to fix the build issue for now and
refactor + replace most of the code when I have time to do it
properly.

Thanks,

Daniel


More information about the U-Boot mailing list