[PATCH] clk: enhance clk-gpio to also handle gated-fixed-clock

[Jonas Karlman]

Hi Torsten,

On 6/11/2026 4:17 PM, Torsten Duwe wrote:
> On Thu, 11 Jun 2026 08:01:05 -0600
> Tom Rini <trini at konsulko.com> wrote:
> 
>> On Thu, Jun 11, 2026 at 03:58:04PM +0200, Jonas Karlman wrote:
>>> Hi Tom,
>>>
>>> On 6/11/2026 3:48 PM, Tom Rini wrote:
>>>> On Thu, 28 May 2026 13:22:06 +0200, Torsten Duwe wrote:
>>>>
>>>>> Devicetree commit a198185b9b5 introduced a new type of clock,
>>>>> "gated-fixed-clock", for which Das U-Boot does not have
>>>>> a driver yet. The required code is similar to gpio-gate-clock,
>>>>> and can be added using little extra text space.
>>>>>
>>>>> Use this code e.g. to boot a Rock5 ITX from NVMe
>>>>>
>>>>> [...]
>>>>
>>>> Applied to u-boot/next, thanks!
>>>
>>> Any reason this was applied without my review concerns being
>>> addressed?
>>>
>>> Please revert, or address the issues this patch have :-)
>>
>> Yes, I missed them, sorry about that. I'll go push a revert along
>> shortly.
>>
> 
> IIRC it was not a big thing, I can also follow up with the change
> suggested by Jonas, if that's easier for you.

There where three issues with this patch:
- wrong regulator_set_enable function used
- regulator is enabled during probe, not when clock is enabled
- regulator is never disabled, resulting in broken/unbalanced reference
  enable count of the regulator

Also keep in mind that there are some issues with the pcie_dw_rockchip
driver to fully and correctly fix gated-fixed-clock use on ROCK 5 ITX.

https://lore.kernel.org/u-boot/20260520-rock-5-itx-pcie-refclk-dtsi-v3-0-58f2cea72030@superkali.me/

Regards,
Jonas

> 
> 	Torsten