[PATCH v3 3/3] test: py: load: check null_dev_desc_ok dispatch

[Simon Glass]

Hi Vincent,

On 2026-06-01T13:12:01, Vincent Jardin <vjardin at free.fr> wrote:
> test: py: load: check null_dev_desc_ok dispatch
>
> Some pytest modules exercising the dispatch added by
>   fs: dispatch null_dev_desc_ok filesystems before lookup
>
> test_load_semihosting.py:
>   "load semihosting - <addr> <file>" and the optional
>   [bytes] [pos] variant. Runs on qemu_arm64 with
>   CONFIG_SEMIHOSTING=y; reuses test_hostfs.py's host-staged
>   fixture.
>
> test_load_sandbox.py:
>   "load sandbox - <addr> <file>" and the optional [bytes] [pos]
>   variant. Runs on sandbox (boardspec('sandbox')); the sandbox
>   fstype is registered with name='sandbox' and
>     null_dev_desc_ok=true,
>   so the same fs_lookup_null_dev_info() helper that
>   routes semihosting also routes the 'sandbox'.
>
> A "load ubifs - <addr> <file>" test is intentionally not provided.
> [...]
>
> test/py/tests/test_load_sandbox.py                 | 53 ++++++++++++++++++++++
>  .../test_semihosting/test_load_semihosting.py      | 39 ++++++++++++++++
>  2 files changed, 92 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

nit below:

> diff --git a/test/py/tests/test_load_sandbox.py b/test/py/tests/test_load_sandbox.py
> @@ -0,0 +1,53 @@
> + at pytest.mark.boardspec('sandbox')
> +def test_sandbox_load(ubman, sandbox_fixture):
> +    """Run load sandbox - <addr> <file> and check the bytes."""
> +    response = ubman.run_command(
> +        f'load sandbox - $loadaddr {sandbox_fixture}')
> +
> +    # Fixture is "Das U-Boot\n" (11 bytes).
> +    assert '11 bytes read' in response
> +    # Negative-guard the pre-patch failure mode.
> +    assert 'Bad device specification' not in response

The negative-guard is redundant. If '11 bytes read' appears we cannot
also have hit the error path. Please drop it.

Regards,
Simon