[PATCH v3 1/6] arm: snapdragon: Make SYSRESET_PSCI optional

Balaji Selvanathan balaji.selvanathan at oss.qualcomm.com
Thu Jun 18 12:37:52 CEST 2026


Hi Casey,

On 6/16/2026 6:21 PM, Casey Connolly wrote:
> Hi Balaji,
>
> On 16/06/2026 11:22, Balaji Selvanathan wrote:
>> In snagboot mode, U-Boot is loaded directly by XBL without a prior
>> bootloader to initialize PSCI firmware. Forcing SYSRESET_PSCI via
>> 'select' causes failures in this scenario. Change to 'imply' to
>> allow it to be disabled when PSCI is unavailable.
> General feedback, I assume you're not writing these descriptions by
> hand, they are overly verbose and don't convey much useful context. This
> doesn't need to be a paragraph, just:
>
> "In snagboot mode, there is no PSCI firmware and U-Boot will crash if it
> attempts to make PSCI calls so disable it in this case."
>
> It isn't acceptable to send me patches like this that have a full
> sentence explaining how it changes a 'select' and an 'imply', i can see
> that from the diff.
>
> Please do better, take 30 seconds to write a sensible commit message.
> This goes for everyone with an @oss.qualcomm.com email

Apologies!! We will try to be consise in our commit descriptions going 
forward.

Regards,

Balaji

>
>> Reviewed-by: Varadarajan Narayanan <varadarajan.narayanan at oss.qualcomm.com>
>> Signed-off-by: Balaji Selvanathan <balaji.selvanathan at oss.qualcomm.com>
>> ---
>> Changes in v3:
>> - No changes
>>
>> Changes in v2:
>> - Newly introduced in v2
>> ---
>>   arch/arm/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 514bf2000b4..a6d36f39069 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1150,7 +1150,7 @@ config ARCH_SNAPDRAGON
>>   	select SAVE_PREV_BL_FDT_ADDR if !ENABLE_ARM_SOC_BOOT0_HOOK
>>   	select LINUX_KERNEL_IMAGE_HEADER if !ENABLE_ARM_SOC_BOOT0_HOOK
>>   	select SYSRESET
>> -	select SYSRESET_PSCI
>> +	imply SYSRESET_PSCI
> Let's not allow disabling SYSRESET_PSCI in defconfigs.
>
> 	select SYSRESET_PSCI if !QCOM_SNAGBOOT_MODE
>
>>   	select ANDROID_BOOT_IMAGE_IGNORE_BLOB_ADDR
>>   	select MMU_PGPROT
>>   	imply OF_UPSTREAM
>>


More information about the U-Boot mailing list