[v1,0/8] bootcount: introduce GPT-backed bootcount device
Simon Glass
sjg at chromium.org
Thu Jun 18 17:54:23 CEST 2026
Hi Denis,
On 2026-06-05T03:38:59, None <dmukhin at ford.com> wrote:
> This series adds new GPT-backed bootcount device with
> ChromiumOS-inspired counters/flags logic [1].
There is no update to doc/api/bootcount.rst describing the new
backend, how to wire it into the DT, or the autoboot interaction
introduced by patch 8. Please add a short section so users can
discover it.
The use of include/cros_flags.h consumed by generic disk and bootcount
code feels awkward - the bootcount driver itself does not include
cros_flags.h, only the gpt command does, and read/write_disk_flags()
operate on plain u16. It might be cleaner to put the generic 16-bit
accessors in part.h (or a new gpt_flags.h) and keep the cros_*
wrappers in cros_flags.h for the cgpt-compatible command surface only.
What do you think?
> Patch 6 introduces the new bootcount device with compatible
> 'u-boot,bootcount-gpt'
I can't find a device-tree binding document for the new compatible.
The other bootcount drivers have entries under
doc/device-tree-bindings/ (e.g. bootcount-syscon.txt,
misc/bootcounter.txt) - please add one describing
'u-boot,bootcount-gpt' and its device-type, devnum and partition-name
properties.
Regards,
Simon
More information about the U-Boot
mailing list