[PATCH v2 3/3] tpm: allocate tpm event log if missing

Ludwig Nussel ludwig.nussel at siemens.com
Mon Jun 29 09:42:56 CEST 2026


On 6/23/26 10:50, Ilias Apalodimas wrote:
> On Tue, 23 Jun 2026 at 11:38, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
>> On Thu, 18 Jun 2026 at 12:16, Ludwig Nussel <ludwig.nussel at siemens.com> wrote:
>>>
>>> On 6/16/26 13:46, Ilias Apalodimas wrote:
>>>>> [...]
>>>>> Anyway, do you want me to submit your two patches as part of the series
>>>>> or you want to follow up yourself?
>>>>
>>>> Carry them over imho, they were rotting in my branches for 1+ years,
>>>> but I never had the chance to send them. Your patches were a good
>>>> reason to rebase and revive them and they fit right in as can only
>>>> rely on tcg2_measurement_init now.  I'll test/check the v4. I haven't
>>>> gone through your changes in depth but they seemed reasonable, so I
>>>> think this is fairly close on getting in
>>>
>>> With the patches on top the testsuite weirdly fails in platforms
>>> xilinx_versal_virt:
>>> [...]
>>> I can't figure out why though. While investigating I noticed that I need
>>> to re-introduce the elog parameter to the measurement functions so the
>>> integration actually has a chance for now, short of using dev->priv->log
>>> always.
>>
>> Ok i'll have a look and see if I can figure out why
> 
> Ok I had a quick look. The reason is that
> if (tcg2_platform_get_tpm2(&dev)) {
> log_warning("Missing TPMv2 device for EFI_TCG_PROTOCOL\n");
> return EFI_SUCCESS;
> }
> 
> Has been removed from the EFI init of the subsystem, but the tests run
> without a TPM. The init now fails and the entire EFI subsystem fails
> to initalize.

Ah, stupid mistake on my part. I've fixed it, the tests are passing now. 
Will resubmit. Thanks!

cu
Ludwig

-- 
Ludwig Nussel
Siemens AG
www.siemens.com


More information about the U-Boot mailing list