[PATCH v2 3/3] rockchip: odroid-m1s: enable watchdog support

Jonas Karlman jonas at kwiboo.se
Mon Jun 29 20:34:26 CEST 2026


Hi Andreas,

On 6/29/2026 7:05 PM, Andreas Zdziarstek wrote:
> The rk3566 ODROID-M1S has a DesignWare watchdog. Enable CONFIG_WDT,
> CONFIG_DESIGNWARE_WATCHDOG and CONFIG_CMD_WDT so it can be driven via
> the wdt command.

I am not a fan of enabling something that is a SoC feature on only one
of the boards that I maintain, especially when ODROID-M1 is part of
same/similar board family.

Maybe we could add a WDT config fragment and imply DESIGNWARE_WATCHDOG
at SoC (or arch) level. At the very least, please extend this to include
both M1 and M1S.

Regards,
Jonas

> 
> CONFIG_WATCHDOG and CONFIG_WATCHDOG_AUTOSTART are left explicitly unset
> to not cause any breaking changes on existing systems.
> 
> Signed-off-by: Andreas Zdziarstek <andreas.zdziarstek at gmail.com>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
> ---
>  configs/odroid-m1s-rk3566_defconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configs/odroid-m1s-rk3566_defconfig b/configs/odroid-m1s-rk3566_defconfig
> index d59882a2a59..943c0509e9e 100644
> --- a/configs/odroid-m1s-rk3566_defconfig
> +++ b/configs/odroid-m1s-rk3566_defconfig
> @@ -30,6 +30,7 @@ CONFIG_CMD_PCI=y
>  CONFIG_CMD_USB=y
>  CONFIG_CMD_ROCKUSB=y
>  CONFIG_CMD_USB_MASS_STORAGE=y
> +CONFIG_CMD_WDT=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_INI=y
>  CONFIG_CMD_PMIC=y
> @@ -87,5 +88,9 @@ CONFIG_USB_DWC3_GENERIC=y
>  CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_DOWNLOAD=y
>  CONFIG_USB_FUNCTION_ROCKUSB=y
> +# CONFIG_WATCHDOG is not set
> +# CONFIG_WATCHDOG_AUTOSTART is not set
> +CONFIG_DESIGNWARE_WATCHDOG=y
> +CONFIG_WDT=y
>  CONFIG_FS_CRAMFS=y
>  CONFIG_ERRNO_STR=y



More information about the U-Boot mailing list