[PATCH v4 2/4] iopoll: Improve handling of timeout_us param in read_poll_timeout macro

Ariel D'Alessandro ariel.dalessandro at collabora.com
Tue Mar 3 14:38:20 CET 2026


Ronan,

On 3/3/26 3:25 AM, Ronan Dalton wrote:
> The read_poll_timeout macro definition is missing parenthesis around the
> usages of timeout_us. Also, the local timeout variable should be named
> __timeout to distinguish it from any variable named timeout in the
> surrounding scope.
> 
> Wrap the timeout_us parameter in brackets and rename timeout to
> __timeout to follow macro definition best-practices.
> 
> This change brings the macro definition more in line with what Linux
> does.

Reviewed-by: Ariel D'Alessandro <ariel.dalessandro at collabora.com>

Thanks for the detailed description!

-- 
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718



More information about the U-Boot mailing list