[RFC PATCH 13/16] binman: test: Move vendor-specific test files to test/vendor/
Quentin Schulz
quentin.schulz at cherry.de
Tue Mar 3 16:25:07 CET 2026
Hi Simon,
On 2/27/26 12:47 AM, Simon Glass wrote:
> From: Simon Glass <simon.glass at canonical.com>
>
> Move about 20 test files for vendor-specific platform support (TI, NXP
> i.MX, Renesas R-Car, Rockchip, PowerPC MPC85xx) into a vendor/
> subdirectory. Drop the numeric prefixes and update all references.
>
What about config.yaml, schema.yaml, schema_notype.yaml
Separate patch is fine.
I'm wondering if we shouldn't go for vendor-specific directories, e.g.
instead of vendor/ti_*.dts, have ti/*.dts.
> Signed-off-by: Simon Glass <simon.glass at canonical.com>
> ---
>
> doc/develop/binman_tests.rst | 8 +--
> tools/binman/ftest.py | 56 +++++++++----------
> .../nxp_ddrfw_imx95.dts} | 0
> .../{339_nxp_imx8.dts => vendor/nxp_imx8.dts} | 0
> .../nxp_imx8_csf.dts} | 0
> .../nxp_imx8_csf_fast_auth.dts} | 0
> .../nxp_imx8_imagename.dts} | 0
> .../nxp_imx95.dts} | 0
> .../powerpc_mpc85xx_bootpg_resetvec.dts} | 0
> .../renesas_rcar4_sa0.dts} | 0
> .../renesas_rcar4_sa0_size.dts} | 0
> .../rockchip_tpl.dts} | 0
> .../ti_board_cfg.dts} | 0
> .../ti_board_cfg_combined.dts} | 0
> .../ti_board_cfg_no_type.dts} | 0
> .../ti_board_cfg_phony.dts} | 0
> .../test/{351_ti_dm.dts => vendor/ti_dm.dts} | 0
> .../ti_secure.dts} | 0
> .../ti_secure_firewall.dts} | 0
> .../ti_secure_firewall_missing_property.dts} | 0
> .../ti_secure_rom.dts} | 0
> .../ti_secure_rom_a.dts} | 0
> .../ti_secure_rom_b.dts} | 0
> .../ti_secure_rom_combined.dts} | 0
> 24 files changed, 32 insertions(+), 32 deletions(-)
> rename tools/binman/test/{353_nxp_ddrfw_imx95.dts => vendor/nxp_ddrfw_imx95.dts} (100%)
This also depends on
https://lore.kernel.org/u-boot/20260225225040.2568118-1-sjg@chromium.org/.
> rename tools/binman/test/{339_nxp_imx8.dts => vendor/nxp_imx8.dts} (100%)
> rename tools/binman/test/{364_nxp_imx8_csf.dts => vendor/nxp_imx8_csf.dts} (100%)
> rename tools/binman/test/{365_nxp_imx8_csf_fast_auth.dts => vendor/nxp_imx8_csf_fast_auth.dts} (100%)
> rename tools/binman/test/{366_nxp_imx8_imagename.dts => vendor/nxp_imx8_imagename.dts} (100%)
> rename tools/binman/test/{359_nxp_imx95.dts => vendor/nxp_imx95.dts} (100%)
> rename tools/binman/test/{150_powerpc_mpc85xx_bootpg_resetvec.dts => vendor/powerpc_mpc85xx_bootpg_resetvec.dts} (100%)
> rename tools/binman/test/{357_renesas_rcar4_sa0.dts => vendor/renesas_rcar4_sa0.dts} (100%)
> rename tools/binman/test/{358_renesas_rcar4_sa0_size.dts => vendor/renesas_rcar4_sa0_size.dts} (100%)
> rename tools/binman/test/{291_rockchip_tpl.dts => vendor/rockchip_tpl.dts} (100%)
> rename tools/binman/test/{293_ti_board_cfg.dts => vendor/ti_board_cfg.dts} (100%)
> rename tools/binman/test/{294_ti_board_cfg_combined.dts => vendor/ti_board_cfg_combined.dts} (100%)
> rename tools/binman/test/{295_ti_board_cfg_no_type.dts => vendor/ti_board_cfg_no_type.dts} (100%)
> rename tools/binman/test/{352_ti_board_cfg_phony.dts => vendor/ti_board_cfg_phony.dts} (100%)
> rename tools/binman/test/{351_ti_dm.dts => vendor/ti_dm.dts} (100%)
> rename tools/binman/test/{296_ti_secure.dts => vendor/ti_secure.dts} (100%)
> rename tools/binman/test/{324_ti_secure_firewall.dts => vendor/ti_secure_firewall.dts} (100%)
> rename tools/binman/test/{325_ti_secure_firewall_missing_property.dts => vendor/ti_secure_firewall_missing_property.dts} (100%)
> rename tools/binman/test/{297_ti_secure_rom.dts => vendor/ti_secure_rom.dts} (100%)
> rename tools/binman/test/{299_ti_secure_rom_a.dts => vendor/ti_secure_rom_a.dts} (100%)
> rename tools/binman/test/{300_ti_secure_rom_b.dts => vendor/ti_secure_rom_b.dts} (100%)
> rename tools/binman/test/{298_ti_secure_rom_combined.dts => vendor/ti_secure_rom_combined.dts} (100%)
>
> diff --git a/doc/develop/binman_tests.rst b/doc/develop/binman_tests.rst
> index c7fa9ae6199..2bdb7756465 100644
> --- a/doc/develop/binman_tests.rst
> +++ b/doc/develop/binman_tests.rst
> @@ -457,7 +457,7 @@ can, which contains the new etype. Put it in a numbered file in
> ``tool/binman/test`` so that it comes last. All the numbers are unique and there
> are no gaps.
>
> -Example from ``tools/binman/test/339_nxp_imx8.dts``:
> +Example from ``tools/binman/test/vendor/nxp_imx8.dts``:
>
> .. code-block:: devicetree
>
We could also do
.. literalinclude:: ../../../tools/binman/test/vendor/nxp_imx8.dts
:language: devicetree
To make sure it's never outdated (not tested). In a separate patch though.
Cheers,
Quentin
More information about the U-Boot
mailing list