[PATCH v3 6/7] test: Add a helper class to create disk images
Tom Rini
trini at konsulko.com
Fri Mar 6 23:23:07 CET 2026
On Fri, Mar 06, 2026 at 12:08:12PM -0700, Simon Glass wrote:
> From: Simon Glass <simon.glass at canonical.com>
>
> Provide a way to create disk images which consist of multiple filesystem
> images.
>
> Signed-off-by: Simon Glass <simon.glass at canonical.com>
> ---
>
> Changes in v3:
> - Remove cur_dir parameter from DiskHelper as suggested by Tom Rini
> - Remove editorialising from commit message
>
> Changes in v2:
> - Explain why setup_image() is left to later
>
> test/py/tests/fs_helper.py | 95 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 95 insertions(+)
Can we please move this to a follow-up series? This is harder to follow
in part because test/py/tests/test_ut.py is the only test that calls
fs_helper.setup_image with second_part=True, but then maybe I'm just
missing it, doesn't do anything with it, we just need an empty partition
to exist?
I'd like to take the first part of this series, then convert the
fs_helper.mk_fs using tests. Then convert test_ut.py (which is
open-coded fallocate/mkfs.vfat/etc calls) to the new class. Then
understand what DiskHelper really needs to do. Perhaps include having a
case where multiple (and non-empty secondary) partitions are used. Then
we'll know we have both the right abstraction and that it works. Thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260306/47104aed/attachment.sig>
More information about the U-Boot
mailing list