[PATCH] reset: Correct dependencies for RESET_RZG2L_USBPHY_CTRL

[Tom Rini]

On Tue, Mar 17, 2026 at 08:41:26PM +0100, Marek Vasut wrote:
> On 3/17/26 2:40 PM, Tom Rini wrote:
> > On Tue, Mar 17, 2026 at 03:33:57AM +0100, Marek Vasut wrote:
> > > On 3/17/26 2:24 AM, Tom Rini wrote:
> > > > As exposed by "make randconfig", we have an issue with the dependencies
> > > > for RESET_RZG2L_USBPHY_CTRL. As REGULATOR_RZG2L_USBPHY depends on
> > > > DM_REGULATOR this symbol must also depend on it as well.
> > > > 
> > > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > > ---
> > > > Cc: Marek Vasut <marek.vasut+renesas at mailbox.org>
> > > > ---
> > > >    drivers/reset/Kconfig | 2 +-
> > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > > > index 66911199c8ba..3f0ec50510c0 100644
> > > > --- a/drivers/reset/Kconfig
> > > > +++ b/drivers/reset/Kconfig
> > > > @@ -239,7 +239,7 @@ config RESET_AT91
> > > >    config RESET_RZG2L_USBPHY_CTRL
> > > >    	bool "Enable support for Renesas RZ/G2L USB 2.0 PHY control"
> > > > -	depends on DM_RESET
> > > > +	depends on DM_RESET && DM_REGULATOR
> > > >    	select REGULATOR_RZG2L_USBPHY
> > > But this already selects REGULATOR_RZG2L_USBPHY , which according to
> > > drivers/power/regulator/Kconfig contains:
> > > 
> > > 508 config REGULATOR_RZG2L_USBPHY
> > > 509         bool "Enable driver for RZ/G2L USB PHY VBUS supply"
> > > 510         depends on DM_REGULATOR
> > > 
> > > which does depend on DM_REGULATOR transitively ?
> > 
> > That's why Kconfig complains about the unmet dependency. "randconfig"
> > does some fun and apparently valid things.
> That's the thing -- if RESET_RZG2L_USBPHY_CTRL depends on
> REGULATOR_RZG2L_USBPHY which depends on DM_REGULATOR, how can DM_REGULATOR
> be unset, while RESET_RZG2L_USBPHY_CTRL is set ?

Using "randconfig" will find some odd problems, yes, because it makes a
(based on what all of the Kconfig files say) possible config and then
forces it to be validated against the expressed logic.

So I think the answer is if you fire up menuconfig, and turn off
RESET_RZG2L_USBPHY_CTRL and REGULATOR_RZG2L_USBPHY and DM_REGULATOR and
then enable RESET_RZG2L_USBPHY_CTRL things will become mad because
RESET_RZG2L_USBPHY_CTRL has select'd REGULATOR_RZG2L_USBPHY but we don't
have DM_REGULATOR.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260317/b3190006/attachment.sig>