[PATCH] EFI Loader: Correct dependencies for EFI_HTTP_BOOT

[Ilias Apalodimas]

On Tue, 17 Mar 2026 at 15:42, Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Mar 17, 2026 at 09:03:47AM +0200, Ilias Apalodimas wrote:
> > Hi Tom,
> >
> > On Tue, 17 Mar 2026 at 03:24, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > As exposed by "make randconfig", we have an issue with the dependencies
> > > for EFI_HTTP_BOOT. As this is implemeneted by running commands (as seen
> > > by what it selects) it must depend on CMDLINE as well.
> > >
> > > Signed-off-by: Tom Rini <trini at konsulko.com>
> >
> > In theory, you can configure UEFI with a set of prebuilt boot options.
> > If one of them is http(s) the device will boot even if CMDLINE is not
> > selected. I am not against this patch, but we will remove the
> > possibility to build a firmware without cmdline that just boots to
> > whatever is was preconfigured
> >
> > Cheers
> > /Ilias
> > > ---
> > > Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > > Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> > > ---
> > >  lib/efi_loader/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> > > index b5f81e0ff530..a9b2f813e1d5 100644
> > > --- a/lib/efi_loader/Kconfig
> > > +++ b/lib/efi_loader/Kconfig
> > > @@ -600,6 +600,7 @@ config EFI_BOOTMGR
> > >  config EFI_HTTP_BOOT
> > >         bool "EFI HTTP Boot support"
> > >         depends on NET || NET_LWIP
> > > +       depends on CMDLINE
> > >         select CMD_NET
> > >         select CMD_DHCP
> > >         select CMD_DNS
>
> The select lines here mean that you cannot do that, today :)

Fair enough. I was just thinking "lets not limit it more".
Heinrich is right though. This needs an overhaul and depend on the
protocols instead of the commands. Either way I don't mind merging it
now, but maybe add a TODO with fixing it in the future?

Thanks
/Ilias

>
> --
> Tom