[PATCH] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible

[Tom Rini]

On Thu, Mar 19, 2026 at 01:50:56AM +0100, Marek Vasut wrote:
> On 3/18/26 2:26 AM, Tom Rini wrote:
> > On Tue, Mar 17, 2026 at 08:42:06PM +0100, Marek Vasut wrote:
> > > On 3/17/26 2:41 PM, Tom Rini wrote:
> > > > On Tue, Mar 17, 2026 at 03:34:36AM +0100, Marek Vasut wrote:
> > > > > On 3/17/26 2:24 AM, Tom Rini wrote:
> > > > > > As exposed by "make randconfig", we have an issue around
> > > > > > USB_GADGET_DUALSPEED. It is possible to select this symbol (via
> > > > > > SPL_USB_CDNS3_GADGET for example) and so have an unmet dependency. As
> > > > > > this is a hidden symbol, move it up within the menu.
> > > > > What is the issue this is fixing ?
> > > > 
> > > > Valid configs causing the kconfig part of the build system to note
> > > > unmet dependencies.
> > > Lemme rephrase, is this actually a fix, or is this some readability/ordering
> > > improvement patch ?
> > 
> > Yes, it's a fix because randconfig finds problems that users may stumble
> > on to while trying to make a valid config for a platform.
> 
> Is the commit message telling me, that "config USB_GADGET_DUALSPEED" is
> moved outside of the "if USB_GADGET" block ?
> 
> Because if this is something else, and the symbols are simply reordered,
> that I do not understand how this could be fixing anything.

I'm unclear what else you need to know to take this bugfix. The symbol
is not placed correctly, leading to possibly unmet dependency errors.
Yes, the error is discovered by randconfig which makes it harder to
describe how exactly to reproduce it (but I believe it does), but that
doesn't make it any less valid.

We'll probably never hit the level of support the kernel has, which is
all randconfigs compile and link (and usually even run), but we should
at least be able to clear out most/all of the Kconfig issues that can be
caught at parse time in a month or two, and maybe even this year have
most CONFIG_SANDBOX=y results build (excluding drivers not fully
configured by Kconfig). And this matters for real users because it means
that downstream developers can probably configure a build rather than
get stuck with odd errors.


-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260319/880ad53b/attachment.sig>