[PATCH RFC 04/40] qcom: rpmh: don't error for SLEEP requests
Casey Connolly
casey.connolly at linaro.org
Thu Mar 19 21:56:26 CET 2026
Just stub them out since the caller might also send active votes. Since
we don't suspend there's no risk of missing votes here, we never enter
the sleep state.
Signed-off-by: Casey Connolly <casey.connolly at linaro.org>
---
drivers/soc/qcom/rpmh-rsc.c | 8 ++++----
drivers/soc/qcom/rpmh.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index dce61f262292..51af5a2a686b 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -260,10 +260,10 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
* U-Boot: since we're single threaded and running synchronously we can
* just always used the first active TCS.
*/
if (msg->state != RPMH_ACTIVE_ONLY_STATE) {
- log_err("WARN: only ACTIVE_ONLY state supported\n");
- return ERR_PTR(-EINVAL);
+ log_debug("WARN: only ACTIVE_ONLY state supported\n");
+ return NULL;
}
return &drv->tcs[ACTIVE_TCS];
}
@@ -389,10 +389,10 @@ int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg)
int tcs_id, i = 0;
u32 val;
tcs = get_tcs_for_msg(drv, msg);
- if (IS_ERR(tcs))
- return PTR_ERR(tcs);
+ if (IS_ERR_OR_NULL(tcs))
+ return PTR_ERR_OR_ZERO(tcs);
/* U-Boot is single-threaded, always use the first TCS as we'll never conflict */
tcs_id = tcs->offset;
if (!read_tcs_reg(drv, drv->regs[RSC_DRV_STATUS], tcs_id)) {
diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
index 8c222324c66d..b55e23c4417d 100644
--- a/drivers/soc/qcom/rpmh.c
+++ b/drivers/soc/qcom/rpmh.c
@@ -59,10 +59,10 @@ static int __rpmh_write(const struct udevice *dev, enum rpmh_state state,
{
struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev);
if (state != RPMH_ACTIVE_ONLY_STATE) {
- log_err("only ACTIVE_ONLY state supported\n");
- return -EINVAL;
+ log_debug("WARN: Only ACTIVE_ONLY state supported\n");
+ return 0;
}
return rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg);
}
--
2.51.0
More information about the U-Boot
mailing list