[PATCH] usb: Correct dependencies around USB_EMUL

[Marek Vasut]

On 3/20/26 9:53 PM, Tom Rini wrote:
> The symbol USB_EMUL is how sandbox has access to USB. It's
> implementation however enforces a few other requirements. It must have
> SCSI enabled, and in turn that means it must have BLK enabled. Finally,
> we should not be using SANDBOX itself as a symbol to decide what to
> build or not build here, as SANDBOX is selected for COMPILE_TEST builds
> as well and so may not have enabled the sandbox specific USB support.
> 
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Cc: Marek Vasut <marek.vasut at mailbox.org>
> ---
>   drivers/usb/emul/Kconfig  | 2 ++
>   drivers/usb/host/Makefile | 2 +-
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/emul/Kconfig b/drivers/usb/emul/Kconfig
> index 279f6c6d7404..8ba372453e37 100644
> --- a/drivers/usb/emul/Kconfig
> +++ b/drivers/usb/emul/Kconfig
> @@ -1,7 +1,9 @@
>   config USB_EMUL
>   	bool "Support for USB device emulation"
>   	depends on SANDBOX
> +	select BLK

The select SCSI and Makefile change I do understand. But why do we also 
need BLK ? I can't find anything which would interact with BLK in the 
sandbox USB emulation ?

>   	select DM_USB
> +	select SCSI
>   	select USB_HOST
>   	help
>   	  Since sandbox does not have access to a real USB bus, it is possible
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> index ef4ce62a680c..9cac53f07c7a 100644
> --- a/drivers/usb/host/Makefile
> +++ b/drivers/usb/host/Makefile
> @@ -5,7 +5,7 @@
>   
>   ifdef CONFIG_$(PHASE_)DM_USB
>   obj-y += usb-uclass.o
> -obj-$(CONFIG_SANDBOX) += usb-sandbox.o
> +obj-$(CONFIG_USB_EMUL) += usb-sandbox.o
>   endif
>   
>   ifdef CONFIG_$(PHASE_)USB_STORAGE