[PATCH] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible
Tom Rini
trini at konsulko.com
Sat Mar 21 18:34:53 CET 2026
On Sat, Mar 21, 2026 at 02:53:13AM +0100, Marek Vasut wrote:
> On 3/20/26 2:53 PM, Tom Rini wrote:
>
> [...]
>
> > > @@ -371,3 +367,11 @@ config SPL_SDP_USB_DEV
> > > so it can be used in compiled environment.
> > >
> > > endif # SPL_USB_GADGET
> > > +
> > > +if USB_GADGET || SPL_USB_GADGET
> > > +
> > > +# Selected by UDC drivers that support high-speed operation.
> > > +config USB_GADGET_DUALSPEED
> > > + bool
> > > +
> > > +endif
> > > "
> >
> > You don't need to guard hidden symbols.
>
> We also do not want to expose this Kconfig symbol unless it makes sense to
> expose it ? In fact, if the symbol is not available and someone attempts to
> use it in Kconfig, they would get a warning, which should provide a clue
> that they are doing something wrong ?
It's a hidden symbol, so it's not exposed to the user. The problem is
that today someone is getting it wrong as you suggest but it's hard to
trigger a warning over it. That said, your patch also fixes the problem,
so:
Reviewed-by: Tom Rini <trini at konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260321/ec3514f0/attachment.sig>
More information about the U-Boot
mailing list