[PATCH v3 1/6] clk: mediatek: mt8189: add some VLP clocks

[Tom Rini]

On Mon, Mar 23, 2026 at 03:16:52PM -0500, David Lechner wrote:

> Add some VLP clocks needed by the PMIC on MT8189 and similar SoCs.
> 
> Signed-off-by: David Lechner <dlechner at baylibre.com>
> ---
>  drivers/clk/mediatek/clk-mt8189.c | 289 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 289 insertions(+)

I'm working on a series now to fix this globally, and it's not a
MediaTek only problem, but:

> @@ -1733,6 +2012,16 @@ U_BOOT_DRIVER(mtk_clk_topckgen) = {
>  	.flags = DM_FLAG_PRE_RELOC,
>  };
>  
> +U_BOOT_DRIVER(mtk_clk_vlpckgen) = {

This is a bad name to use. I bet in other parts of the series you re-use
it. These names need to be unique within a binary, and while today they
will be I bet (since all the other examples are fine), someday we'd like
to be able to compile test (and so static analyize) more code, and it
will clash and fail to link. A better one would be
"mt8189_clk_vlpckgen".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260323/a6203da6/attachment.sig>