[PATCH 1/2] firmware: scmi: Fix setting the function

[Michal Simek]

On 3/26/26 13:08, Dan Carpenter wrote:
> Set BIT(10) when the function needs to be set, otherwise the setting is
> ignored.
> 
> Fixes: 1048331f5d3c ("scmi: pinctrl: add pinctrl driver for SCMI")
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> ---
>   drivers/firmware/scmi/pinctrl.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/firmware/scmi/pinctrl.c b/drivers/firmware/scmi/pinctrl.c
> index 47f7a8ad9b81..e670538c87f9 100644
> --- a/drivers/firmware/scmi/pinctrl.c
> +++ b/drivers/firmware/scmi/pinctrl.c
> @@ -259,6 +259,8 @@ static int scmi_pinctrl_settings_configure_helper(struct udevice *dev,
>   	in->attr = 0;
>   	in->attr |= FIELD_PREP(GENMASK(9, 2), num_configs);
>   	in->attr |= FIELD_PREP(GENMASK(1, 0), select_type);
> +	if (function_id != SCMI_PINCTRL_FUNCTION_NONE)
> +		in->attr |= BIT(10);

hm shouldn't be macros to use for holding that value instead?

As I see GENMASK above is the same case.

>   	memcpy(in->configs, configs, num_configs * sizeof(u32) * 2);

Another magic here.

M