[PATCH v3] binman: add CST backend selection for i.MX8M signing

[Simon Glass]

Hi Marek,

On Sun, 29 Mar 2026 at 08:25, Marek Vasut <marex at nabladev.com> wrote:
>
> On 3/29/26 2:09 PM, Simon Glass wrote:
> > Hi Marek,
> >
> > On Sat, 21 Mar 2026 at 13:52, Marek Vasut <marex at nabladev.com> wrote:
> >>
> >> Add support for setting the CST backend, both via DT property and
> >> CST_BACKEND environment variable. The CST currently supports two
> >> backends, 'ssl' and 'pkcs11', with 'ssl' being the default when
> >> CST tool is invoked without any -b parameter. Keep 'ssl' backend
> >> as the default, but explicitly pass it via the '-b' parameter,
> >> unless the user selects 'pkcs11' via either method.
> >>
> >> Signed-off-by: Marek Vasut <marex at nabladev.com>
> >> ---
> >> Cc: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> >> Cc: Simon Glass <sjg at chromium.org>
> >> Cc: Tom Rini <trini at konsulko.com>
> >> Cc: u-boot at lists.denx.de
> >> ---
> >> V2: Fill in documentation for all used DT properties
> >> V3: Fill third copy of documentation into nxp_imx8mcst.py
> >> ---
> >>   doc/imx/habv4/guides/mx8m_spl_secure_boot.txt | 30
++++++++++++-------
> >>   tools/binman/entries.rst                      |  7 +++++
> >>   tools/binman/etype/nxp_imx8mcst.py            | 19 +++++++++++-
> >>   3 files changed, 44 insertions(+), 12 deletions(-)
> >>
> >
> > This is missing coverage for line 177 of nxp_imx8mcst.py:
> >
> >     cst_backend = "pkcs11"
> >
> > Please can you use (or mock) this feature in a test.
> I already invested a lot of effort into binman tests before in [PATCH]
> binman: Fill in most of the imx8mimage and imx8mcst tests and it went
> nowhere.
>
> Can you provide (an example of) such a test ?

Yes you created quite a few tests. Then I invested a lot of time to finish
it off[1] so that we are finnaly back up to 100%

Since you are adding a new feature your may need a test file with a
'nxp,cst-backend' set to 'pkcs11'

Regards,
Simon

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=494765&state=*