[3/4] fwu: add helper to get image GUID by type and bank index

Simon Glass sjg at chromium.org
Tue Mar 31 17:00:21 CEST 2026


Hi Dario,

On 2026-03-28T17:15:13, Dario Binacchi
<dario.binacchi at amarulasolutions.com> wrote:
> diff --git a/include/fwu.h b/include/fwu.h
> @@ -394,6 +394,9 @@ int fwu_get_mdata_size(uint32_t *mdata_size);
> +int fwu_mdata_get_image_guid(efi_guid_t *image_guid, efi_guid_t image_type_guid,
> +                          u32 bank_index);

Please add a function comment like the other.

Also, all other functions in this file pass efi_guid_t by pointer. How
about 'const efi_guid_t *image_type_guid' instead?

> diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c
> @@ -243,6 +243,30 @@ int fwu_sync_mdata(struct fwu_mdata *mdata, int part)
> +}
>  /**
>   * fwu_mdata_copies_allocate() - Allocate memory for metadata

Missing blank line between the closing brace of the new function and
the doc comment of fwu_mdata_copies_allocate().

Regards,
Simon


More information about the U-Boot mailing list