[v3,3/7] mach-snapdragon: Integrate reboot-mode handling

[Simon Glass]

Hi Aswin,

On 2026-03-30T17:14:12, Aswin Murugan <aswin.murugan at oss.qualcomm.com> wrote:
> diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c
> @@ -506,6 +507,33 @@ void qcom_show_boot_source(void)
> +static void qcom_handle_reboot_mode(void)
> +{

The function is defined unconditionally but only called inside #if
IS_ENABLED(CONFIG_DM_REBOOT_MODE)

How about just adding 'if (!IS_ENABLED(CONFIG_DM_REBOOT_MODE)) return'
in the function?

> diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c
> @@ -506,6 +507,33 @@ void qcom_show_boot_source(void)
> +             printf("Entering fastboot mode due to reboot reason...\n");

The rest of this file uses the logging subsystem ('log_info',
'log_warning', etc.) with LOG_CATEGORY set to LOGC_BOARD. Do you want
to do the same here?

> diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c
> @@ -506,6 +507,33 @@ void qcom_show_boot_source(void)
> +             run_command("run fastboot", 0);

Worth at least logging a warning if 'run_command' returns non-zero, so
the user knows something went wrong.

Regards,
Simon