[PATCH v1 3/3] fdt_support: prefer __func__ over __FUNCTION__

Tom Rini trini at konsulko.com
Mon May 25 16:43:31 CEST 2026


On Mon, May 25, 2026 at 01:26:25PM +0000, Aristo Chen wrote:

> A handful of printf call sites in fdt_fixup_memory_banks,
> __of_translate_address and fdt_get_dma_range still use the
> gcc-specific __FUNCTION__ identifier. checkpatch.pl prefers the
> C99-standard __func__ for new code, and the rest of this file already
> uses __func__, so convert the remaining occurrences for consistency.
> 
> While in __of_translate_address, also re-align the continuation line
> of the inner Bad cell count printf so the second argument lines up
> with the open parenthesis of its printf instead of being one column
> off, silencing the alignment check that scripts/checkpatch.pl reports
> on the cleanup hunk. No behavioural change.
> 
> Signed-off-by: Aristo Chen <aristo.chen at canonical.com>

Oh wow, I didn't realize we still had __FUNCTION__ anywhere in the code.
Can you please move this to it's own series and do a global fixup of
__FUNCTION__ -> __func__ ? Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260525/2af7449b/attachment.sig>


More information about the U-Boot mailing list