[U-Boot-Users] request for comments

[Josh Fryman]

hi all,

i've got a set of patches i've been working on to support a new platform.
it's still a work-in-progress, but a couple of issues have come up that
i'd like to ask for input on.

this platform has an LCD panel and a backlight.  both are controllable to
a certain extent.  i'd like to add a set of new commands to support the
features:

   bkon                        backlight on
   bkoff                       backlight off
   bkset percent               set backlight brightness to "percent" of max
   lcdon                       turn lcd on
   lcdoff                      turn lcd off
   lcdtst                      draw a test pattern on the lcd
   lcddraw x0 y0 x1 y1 r g b   draw a rectangle on the lcd, scaling R/G/B
                               values to hardware supported (ie, the cmd
                               values are in 0-255, but the hardware only
                               does RGB565 ... causes "255" to be mapped
                               accordingly)

and accompanying cmd_lcd.c, and cmd_bklite.c files.

of course, i could re-work this to be more like

   bk   {on,off,set percent}
   lcd  {on,off,tst,draw x0 y0 x1 y1 r g b}

to not take up so many command values...

any thoughts?  

-josh