[U-Boot-Users] changes for IDS8247 Board

[Scott Wood]

On Thu, Aug 02, 2007 at 01:03:44PM +0200, Sergej Stepanov wrote:
> +#define OF_CPU "PowerPC,8247 at 0"
> +#define OF_SOC "soc8247 at e0008000"
> +#define OF_TBCLK (bd->bi_busfreq / 4)
> +#define OF_STDOUT_PATH "/soc8247 at e0008000/console at 0000"

We're trying to get away from model numbers in the soc node; could you
make it soc at e0008000 instead?

> +#if 1 /* FCC */
> +/*
> + * - Rx-CLK is CLK10
> + * - Tx-CLK is CLK9
> + * - RAM for BD/Buffers is on the 60x Bus (see 28-13)
> + * - Enable Full Duplex in FSMR
> + */
> +# define CFG_CMXFCR_MASK	(CMXFCR_FC1|CMXFCR_RF1CS_MSK|CMXFCR_TF1CS_MSK)
> +# define CFG_CMXFCR_VALUE	(CMXFCR_RF1CS_CLK10|CMXFCR_TF1CS_CLK9)
> +# define CFG_CPMFCR_RAMTYPE	0
> +# define CFG_FCC_PSMR		(FCC_PSMR_FDE|FCC_PSMR_LPB)
> +#else

Don't use #if 1; Either provide something meaningful to #ifdef/#ifndef on
(even if it's curently always/never set), or remove the alternate code.

>  /* SDRAM initialization values
>  */
> -#define CFG_OR2    ((~(CFG_GLOBAL_SDRAM_LIMIT-1) & ORxS_SDAM_MSK) |\
> +/*#define CFG_OR2    ((~(CFG_GLOBAL_SDRAM_LIMIT-1) & ORxS_SDAM_MSK) |	\
>  			 ORxS_BPD_4                     |\
>  			 ORxS_ROWST_PBI0_A10             |\
>  			 ORxS_NUMR_12)
> +*/
> +#define CFG_OR2    ((~(CFG_GLOBAL_SDRAM_LIMIT-1) & ORxS_SDAM_MSK) |\
> +			 ORxS_BPD_4                     |\
> +			 ORxS_ROWST_PBI0_A9             |\
> +			 ORxS_NUMR_12)
> +

Likewise, no commented out code, please.  If you're trying to support
multiple versions or configurations of the board, use an ifdef.

-Scott