[U-Boot-Users] RFC: Common bitshifts

[Peter Pearse]

Dear All 
 
I'd like some guidance here:-
 
An arm patch for a new board has been submitted. Part of the patch is to add
the new file:-
 
include/asm-arm/arch-arm1176/bits.h

defining standard bit shifts e.g
 
#define BIT0  (1<<0)
#define BIT1  (1<<1)
#define BIT2  (1<<2)
#define BIT3  (1<<3)
#define BIT4  (1<<4)
#define BIT5  (1<<5)

I notice there is already a file:-
 
include/asm-arm/arch-arm113/bits.h
 
with identical contents.
 
a) Is it acceptable to replace these two (and references thereto) with 
include/bitshifts.h?
 
The shifts are not arm specific, and could be useful to others.
 
b) If so, should I submit a seperate patch to the main tree, or is it
acceptable to make this part of the
patch for the new board?
 
Regards
 
Peter 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20070312/7da40b5d/attachment.htm