[U-Boot-Users] [PATCH] cfi_flash.c: use addr2info

Tolunay Orkun listmember at orkun.us
Wed May 2 23:50:48 CEST 2007


Ladislav Michl wrote:
> On Fri, Mar 23, 2007 at 12:52:35PM +0100, Ladislav Michl wrote:
>> Hi,
>>
>> cfi_flash.c is providing functionality already present elsewhere as
>> addr2info (in common/flash.c). Lets save few bytes by using it.
> 
> Tolunay, any comments?

I am all for removing redundant code.

I looked at your patch when you submitted but did not carefully review 
yet. I feel like the function should reside inside the flash driver 
where it is most often used and flash driver should export it.

Tolunay





More information about the U-Boot mailing list