[U-Boot-Users] [PATCH 3/3] Apollon BSP support

[Wolfgang Denk]

In message <20070914005221.GA14750 at party> you wrote:
> Apollon BSP support
> 
> The Apollon based on OMAP2420 is designed for OneNAND development.
> It's similar with OMAP2420 H4 except some peripherals.
> 
> Now this board is maintained at mainline kernel.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
> diff --git a/board/apollon/mem.c b/board/apollon/mem.c
> new file mode 100644
> index 0000000..a4980b0
> --- /dev/null
> +++ b/board/apollon/mem.c
...
> +/*********************************************************************************
> + * prcm_init() - inits clocks for PRCM as defined in clocks.h (config II default).
> + *   -- called from SRAM, or Flash (using temp SRAM stack).
> + *********************************************************************************/

Maximum line length exceeded.

...
> +	__raw_writel(APOLLON_24XX_GPMC_CONFIG7_0, GPMC_CONFIG7_0);	/* enable new mapping */

Maximum line length exceeded.

...
> +#ifdef PRCM_CONFIG_I
> +# define APOLLON_2420_SDRC_ACTIM_CTRLA_0	APOLLON_242X_SDRC_ACTIM_CTRLA_0_166MHz
> +# define APOLLON_2420_SDRC_ACTIM_CTRLB_0	APOLLON_242X_SDRC_ACTIM_CTRLB_0_166MHz
> +# define APOLLON_2420_SDRC_RFR_CTRL		APOLLON_242X_SDRC_RFR_CTRL_166MHz
> +# define APOLLON_2420_SDRC_DLLAB_CTRL		APOLLON_242x_SDRC_DLLAB_CTRL_166MHz
> +#elif PRCM_CONFIG_II
> +# define APOLLON_2420_SDRC_ACTIM_CTRLA_0	APOLLON_242X_SDRC_ACTIM_CTRLA_0_100MHz
> +# define APOLLON_2420_SDRC_ACTIM_CTRLB_0	APOLLON_242X_SDRC_ACTIM_CTRLB_0_100MHz
> +# define APOLLON_2420_SDRC_RFR_CTRL		APOLLON_242X_SDRC_RFR_CTRL_100MHz
> +# define APOLLON_2420_SDRC_DLLAB_CTRL		APOLLON_242x_SDRC_DLLAB_CTRL_100MHz
> +#endif

Maximum line length exceeded.


> diff --git a/include/configs/apollon.h b/include/configs/apollon.h
> new file mode 100644
> index 0000000..7c8d447
> --- /dev/null
> +++ b/include/configs/apollon.h
...
> +#ifdef CONFIG_APOLLON_PLUS
> +#define CONFIG_BOOTARGS          "root=/dev/nfs rw mem=64M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2"
> +#else
> +#define CONFIG_BOOTARGS          "root=/dev/nfs rw mem=128M console=ttyS0,115200n8 ip=192.168.116.25:192.168.116.1:192.168.116.1:255.255.255.0:apollon:eth0:off nfsroot=/tftpboot/nfsroot profile=2"
> +#endif

Maximum line length exceeded.

> +
> +#define CONFIG_EXTRA_ENV_SETTINGS					\
> +	"Image=tftp 0x80008000 Image\; go 0x80008000\0"			\
> +	"zImage=tftp 0x80180000 zImage\; go 0x80180000\0"		\
> +	"uImage=tftp 0x80180000 uImage\; bootm 0x80180000\0"		\
> +	"uboot=tftp 0x80008000 u-boot.bin\; go 0x80008000\0"		\
> +	"xloader=tftp 0x80180000 x-load.bin\; cp.w 0x80180000 0x00000400 0x1000\; go 0x00000400\0"	\

Maximum line length exceeded.

> +	"syncmode50=mw.w 0x1e442 0xc0c4\; mw 0x6800a060 0xe30d1201\0"	\
> +	"syncmode=mw.w 0x1e442 0xe0f4\; mw 0x6800a060 0xe30d1201\0"	\
> +	"norboot=cp32 0x18040000 0x80008000 0x200000\; go 0x80008000\0"	\
> +	"oneboot=onenand read 0x80008000 0x40000 0x200000\; go 0x80008000\0"\
> +	"onesyncboot=run syncmode oneboot\0"				\
> +	"bootcmd=run uboot\0"

Please remove the bogus backslash-escapes for the semicolons h.

Please note that booting a Linux kernel using the "go" command is
not a good idea. I would not add this to a default environment.

....
> +#define CONFIG_NR_DRAM_BANKS     1                 /* CS1 may or may not be populated */

Maximum line length exceeded.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
READ THIS BEFORE OPENING PACKAGE: According to Certain Suggested Ver-
sions of the Grand Unified Theory, the Primary Particles Constituting
this Product May Decay to Nothingness Within the  Next  Four  Hundred
Million Years.