[U-Boot] [PATCH v2 0/2] net: Additional IP fragmentation check

Ben Warren biggerbadderben at gmail.com
Fri Dec 5 08:08:07 CET 2008


Hi Peter,

Peter Tyser wrote:
> v2: Forgot SOBs...
>
> It looks like U-Boot ignores fragmented IP packets with
> non-zero "fragment offset" fields, but doesn't ignore the
> initial fragmented IP packet which has a "fragment offset"
> field value of 0.
>
> An additional check was added to catch the initial
> fragmented packet which should have the "more fragments"
> bit set in its flags field.
>
> The bug initially resulted in TFTP transfers which
> appeared to work, but in reality failed as some
> fragmented packets were received, others were not.
> With these patches applied a TFTP download from a
> server with a low MTU results in a timeout as U-Boot
> drops all incominig fragmented TFTP data packets.
>
>
> I quickly tried the "Add simple IP/UDP fragmentation
> support" patch in the net/testing repository, but
> it did not work out of the box.  It looks like U-Boot
> was assembling the fragmented packets correctly based on
> a memory display of &NetFragBuf, but the assembled
> packet was not making its way up the stack FWIW.
>
> Peter Tyser (2):
>   net: Define IP flag field values
>   net: Add additional IP fragmentation check
>
>  include/net.h |    6 ++++++
>  net/net.c     |    8 +++++---
>  2 files changed, 11 insertions(+), 3 deletions(-)
>   
Patches 1 and 2 applied to net repo.

thanks,
Ben


More information about the U-Boot mailing list