[U-Boot] [PATCH] net: tsec: Fix Marvell 88E1121R phy init

Ben Warren biggerbadderben at gmail.com
Fri Dec 5 08:09:53 CET 2008


Hi Anatolij & Andy,

Andy Fleming wrote:
> On Tue, Dec 2, 2008 at 3:31 AM, Anatolij Gustschin <agust at denx.de> wrote:
>   
>> This patch tries to ensure that phy interrupt pin
>> won't be asserted after booting. We experienced
>> following issues with current 88E1121R phy init:
>>
>> Marvell 88E1121R phy can be hardware-configured
>> to share MDC/MDIO and interrupt pins for both ports
>> P0 and P1 (e.g. as configured on socrates board).
>> Port 0 interrupt pin will be shared by both ports
>> in such configuration. After booting Linux and
>> configuring eth0 interface, port 0 phy interrupts
>> are enabled. After rebooting without proper eth0
>> interface shutdown port 0 phy interrupts remain
>> enabled so any change on port 0 (link status, etc.)
>> cause assertion of the interrupt. Now booting Linux
>> and configuring eth1 interface will cause permanent
>> phy interrupt storm as the registered phy 1 interrupt
>> handler doesn't acknowledge phy 0 interrupts. This
>> of course should be fixed in Linux driver too.
>>     
>
> Agreed, and...
>
>   
>> Signed-off-by: Anatolij Gustschin <agust at denx.de>
>>     
>
> Acked-by: Andy Fleming <afleming at freescale.com>
>   
Applied to net repo.

thanks,
Ben


More information about the U-Boot mailing list