[U-Boot] [PATCH v4] ppc4xx: Add GDsys PowerPC 440 ETX board support.

Stefan Roese sr at denx.de
Tue Dec 9 11:22:03 CET 2008


On Tuesday 09 December 2008, Dirk Eibach wrote:
> Board support for the Guntermann & Drunck PowerPC 440 ETX module.
> Based on the AMCC Yosemite board support by Stefan Roese.
>
> Signed-off-by: Dirk Eibach <eibach at gdsys.de>
> ---
>
>  Depends on [PATCH v3] ppc4xx: Improve DDR autodetect
>
>  Removed legacy includes in board/gdsys/gdppc440etx/gdppc440etx.c.
>  Used mfebc()/mtebc() in board/gdsys/gdppc440etx/gdppc440etx.c.
>  Identation with tabs instead of spaces in include/configs/gdppc440etx.h.

Still some nitpicking comments below.

<snip>

> diff --git a/include/configs/gdppc440etx.h b/include/configs/gdppc440etx.h
> new file mode 100644
> index 0000000..edee177
> --- /dev/null
> +++ b/include/configs/gdppc440etx.h
> @@ -0,0 +1,194 @@
> +/*
> + * (C) Copyright 2008
> + * Dirk Eibach,  Guntermann & Drunck GmbH, eibach at gdsys.de
> + *
> + * Based on include/configs/yosemite.h
> + * (C) Copyright 2005-2007
> + * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +/*
> + * gdppc440etx.h - configuration for G&D 440EP/GR ETX-Module
> + */
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +/*
> + * High Level Configuration Options
> + */
> +#define CONFIG_440GR		1	   /* Specific PPC440GR support */
> +#define CONFIG_HOSTNAME		gdppc440etx
> +#define CONFIG_440		1          /* ... PPC440 family         */
> +#define CONFIG_4xx		1          /* ... PPC4xx family         */
> +#define CONFIG_SYS_CLK_FREQ	66666666   /* external freq to pll      */

Please use tab to indent to the comment column as well. 

> +
> +/*
> + * Include common defines/options for all AMCC eval boards
> + */
> +#include "amcc-common.h"
> +
> +#define CONFIG_BOARD_EARLY_INIT_F	1     /* call board_early_init_f*/
> +#define CONFIG_MISC_INIT_R		1     /* call misc_init_r()     */
> +
> +/*
> + * Base addresses -- Note these are effective addresses where the
> + * actual resources get mapped (not physical addresses)
> + */
> +#define CONFIG_SYS_FLASH_BASE		0xfc000000  /* start of FLASH    */
> +#define CONFIG_SYS_PCI_MEMBASE		0xa0000000  /* mapped pci memory */
> +#define CONFIG_SYS_PCI_MEMBASE1		CONFIG_SYS_PCI_MEMBASE  + 0x10000000
> +#define CONFIG_SYS_PCI_MEMBASE2		CONFIG_SYS_PCI_MEMBASE1 + 0x10000000
> +#define CONFIG_SYS_PCI_MEMBASE3		CONFIG_SYS_PCI_MEMBASE2 + 0x10000000
> +
> +/*Don't change either of these*/
> +#define CONFIG_SYS_PERIPHERAL_BASE	0xef600000  /* internal peripherals */
> +#define CONFIG_SYS_PCI_BASE		0xe0000000  /* internal PCI regs */
> +/*Don't change either of these*/
> +
> +#define CONFIG_SYS_USB_DEVICE		0x50000000
> +#define CONFIG_SYS_BOOT_BASE_ADDR	0xf0000000
> +
> +/*
> + * Initial RAM & stack pointer (placed in SDRAM)
> + */
> +#define CONFIG_SYS_INIT_RAM_DCACHE	1     /* d-cache as init ram    */
> +#define CONFIG_SYS_INIT_RAM_ADDR	0x70000000 /* DCache            */
> +#define CONFIG_SYS_INIT_RAM_END		(4 << 10)
> +#define CONFIG_SYS_GBL_DATA_SIZE	256   /* num bytes initial data */
> +#define CONFIG_SYS_GBL_DATA_OFFSET	(CONFIG_SYS_INIT_RAM_END \
> +					 - CONFIG_SYS_GBL_DATA_SIZE)
> +#define CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_GBL_DATA_OFFSET
> +
> +/*
> + * Serial Port
> + */
> +#define CONFIG_SYS_EXT_SERIAL_CLOCK	11059200 /* use ext. 11.059MHz clk */
> +#define CONFIG_UART1_CONSOLE
> +
> +/*
> + * Environment
> + * Define here the location of the environment variables (FLASH or
> EEPROM). + * Note: DENX encourages to use redundant environment in FLASH.
> + */
> +#define CONFIG_ENV_IS_IN_FLASH		1  /* use FLASH for environment vars */
> +
> +/*
> + * FLASH related
> + */
> +#define CONFIG_SYS_FLASH_CFI		    /* The flash is CFI compatible*/
> +#define CONFIG_FLASH_CFI_DRIVER		    /* Use common CFI driver	*/
> +#define CONFIG_SYS_FLASH_CFI_AMD_RESET	1   /* AMD RESET for STM
> 29W320DB!*/ +
> +#define CONFIG_SYS_MAX_FLASH_BANKS	1   /* max number of memory banks  */
> +#define CONFIG_SYS_MAX_FLASH_SECT	512 /* max number of sectors/chip */
> +
> +#define CONFIG_SYS_FLASH_ERASE_TOUT 	120000 /* Timeout/Flash Erase (in ms)
> */ +#define CONFIG_SYS_FLASH_WRITE_TOUT	500    /* Timeout/Flash Write (in
> ms) */ +
> +#define CONFIG_SYS_FLASH_USE_BUFFER_WRITE 1/* use buffered writes (20x
> faster)*/ +
> +#define CONFIG_SYS_FLASH_EMPTY_INFO /* print 'E' for empty sector on
> flinfo */ +
> +#ifdef CONFIG_ENV_IS_IN_FLASH
> +#define CONFIG_ENV_SECT_SIZE		0x20000 /* size of one complete sector*/
> +#define CONFIG_ENV_ADDR		(CONFIG_SYS_MONITOR_BASE-CONFIG_ENV_SECT_SIZE)
> +#define	CONFIG_ENV_SIZE			0x2000 /* Total Size of Env. Sector */

Space instead of tab after "#define".

> +
> +/* Address and size of Redundant Environment Sector */
> +#define CONFIG_ENV_ADDR_REDUND		(CONFIG_ENV_ADDR-CONFIG_ENV_SECT_SIZE)
> +#define CONFIG_ENV_SIZE_REDUND		(CONFIG_ENV_SIZE)
> +#endif /* CONFIG_ENV_IS_IN_FLASH */
> +
> +/*
> + * DDR SDRAM
> + */
> +#undef CONFIG_SPD_EEPROM		/* Don't use SPD EEPROM for setup*/
> +#define CONFIG_SYS_KBYTES_SDRAM		(128 * 1024)    /* 128MB         */
> +#define CONFIG_SYS_SDRAM_BANKS		(2)
> +
> +#define CONFIG_SDRAM_BANK0
> +#define CONFIG_SDRAM_BANK1
> +
> +#define	CONFIG_SYS_SDRAM0_TR0		0x410a4012
> +#define	CONFIG_SYS_SDRAM0_WDDCTR	0x40000000

Space instead of tab after "#define".

> +
> +#undef CONFIG_SDRAM_ECC
> +
> +/*
> + * I2C
> + */
> +#define CONFIG_SYS_I2C_SPEED		400000 /* I2C speed+slave address*/
> +
> +/*
> + * Default environment variables
> + */
> +#define	CONFIG_EXTRA_ENV_SETTINGS					\

Space instead of tab after "#define".

> +	CONFIG_AMCC_DEF_ENV						\
> +	CONFIG_AMCC_DEF_ENV_POWERPC					\
> +	CONFIG_AMCC_DEF_ENV_NOR_UPD					\
> +	"kernel_addr=fc000000\0"					\
> +	"ramdisk_addr=fc180000\0"					\
> +	""

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list