[U-Boot] [PATCH v5] ppc4xx: Add GDsys PowerPC 440 ETX board support.
Eibach, Dirk
Eibach at gdsys.de
Tue Dec 9 12:58:56 CET 2008
Hi Stefan,
> It's really not a big deal, but since I addressed these
> issues in my last mail again, I noticed them in this version as well.
>
> <snip>
>
> > +#define CONFIG_SYS_SDRAM0_TR0 0x410a4012
> > +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000
Oops. Sorry. I thought I had eliminated all of those nasty buggers.
If I ever get to talk to the person I copied that stuff from... :)
> Tab after #define! You seem to have missed this one. Did you
> ever try running checkpatch on your patch? This should spot
> such problems.
In fact my version of checkpatch (linux 2.6.27) does not :(
That is why the last one slipped through.
Which version of checkpatch are you using?
Cheers
Dirk
More information about the U-Boot
mailing list