[U-Boot] [PATCH v3 2/2] ppc4xx: Add PPC4xx SPI helpers to Sequoia

[Steven A. Falco]

Wolfgang Denk wrote:
> Dear Ben Warren,
> 
> In message <493EA876.7090008 at gmail.com> you wrote:
>> Why not enable this feature on Sequoia?  Wolfgang's argument for keeping 
>> the patch out then goes away.  IMHO, eval boards should have as many 
>> options enabled by default as possible, and the user then has the option 
>> to opt out.
> 
> But there is not a single SPI device on the Sequoia board, and if you
> attach one, you have to write driver code for it that implements  the
> chip  select handling and the specific device protocol. We would have
> a driver included, without any  "users"  (code  that  actually  calls
> these functions).
> 
> In other words, this driver is a prerequisite for  other  SPI  device
> drivers  that  might  follow  later,  but as is, it's just a waste of
> memory.
> 
> It would just waste memory to enable it.
Makes sense.
> 
> Best regards,
> 
> Wolfgang Denk
> 
The problem is that if it isn't accepted now, nobody is likely to remember
that it is available, and so they will have to re-write it.  Also, it will
suffer from bit-rot, if just left as a loose patch.

	Steve