[U-Boot] PATCH: mpc8xx PLPRCR (init_pll_866)

Wolfgang Denk wd at denx.de
Wed Dec 10 00:26:03 CET 2008


Dear Spencer Putt,

In message <OF804207B5.958BB343-ON86257506.0064304D-86257506.00643054 at mck.us.ray.com> you wrote:
> 
> Signed-off-by:
> Spencer Putt
> Raytheon Company
> 
> The current init_pll_866 makes a bad assumption for the oscillator.  A
> board with a slower oscillator may lead to PLPRCR fields overflowing their
> bounds and making the board not boot.  This patch should more accurately
> set the PLPRCR regardless of the oscillator, and will increase the
> probability a board will boot by doing some bounds checking.
> 
> --- cpu_mpc8xx_speed.c 2008-10-16 15:37:10.000000000 -0400
> +++ speed.c 2008-10-16 15:35:44.000000000 -0400
> @@ -313,56 +313,60 @@
> }
> /* Configure PLL for MPC866/859/885 CPU series
> - * PLL multiplication factor is set to the value nearest to the desired
> clk,
> - * assuming a oscclk of 10 MHz.
> + * PLL multiplication factor is set to the value nearest to the desired
> clk
> + * If the clk is unattainable, it is set to the highest possible, OSCLK*16
> */
> static long init_pll_866 (long clk)
> {
> extern void plprcr_write_866 (long);
> volatile immap_t *immr = (immap_t *) CFG_IMMR;
> - long n, plprcr;
> - char mfi, mfn, mfd, s, pdf;
> - long step_mfi, step_mfn;
> -
> - if (clk < 20000000) {
> - clk *= 2;
> - pdf = 1;
> - } else {
> - pdf = 0;
> - }

Your patch is completely white-space corrupted, probably by your Lotus
mailer.

Please retry sending after fixing your mail configuration. It is best
when you use git-format-patch to create the patch and  git-send-email
to send it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.


More information about the U-Boot mailing list