[U-Boot] [PATCH 3/6] jffs2: rewrite jffs2 scanning code based on Linux one

Ilya Yanok yanok at emcraft.com
Thu Dec 11 03:49:03 CET 2008


Hi Stefan,

Stefan Roese wrote:
> After this patch is now applied to the main u-boot repo, I get the
> following warning when compiling my new board with OneNAND & JFFS2
> support:
>
> [stefan at kubuntu u-boot (vcth-onenand-ubi-ver3)]$ make -s -j5
> jffs2_1pass.c:1411:1: warning: "min_t" redefined
> In file included 
> from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd-abi.h:11,
>                  from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd.h:11,
>                  from jffs2_1pass.c:275:
> /home/stefan/git/u-boot/u-boot/include/linux/mtd/compat.h:34:1: warning: this is 
> the location of the previous definition
>
> As it seems you added the "min_t" define to this file (see below). Why
> was this needed? I can safely remove it from my version. Do you see a
> problem with removing it on your test platform?
>   

Thanks for reporting. That's obviously because we already have min_t
definition in <linux/mtd/compat.h> and OneNAND  support includes this
header from somewhere while NOR support doesn't. I've changed
jffs2_1pass.c to directly include <linux/mtd/compat.h>  directly instead
of defining own min_t. Please see patch in the follow up message.

Regards, Ilya.



More information about the U-Boot mailing list