[U-Boot] pci_hose_{bus_to_phys,phys_to_bus} and inbound memory

Wolfgang Denk wd at denx.de
Fri Dec 12 01:02:48 CET 2008


Dear Kumar,

In message <AB3960D1-288C-4A22-B9CF-9929C6B68CC7 at kernel.crashing.org> you wrote:
> 
> On Dec 4, 2008, at 10:58 AM, Kumar Gala wrote:
> 
> > We have an issue with inbound windows overlapping outbound windows.
> > This is fine, but it does mean that pci_hose_{bus_to_phys,phys_to_bus}
> > can return the wrong thing.
> >
> > I was wondering if there was any issue if PCI_REGION_MEMORY was set
> > for a region if we skipped that region in the lookup functions:
> >
> > pci_hose_phys_to_bus(...)
> > {
> > ...
> >         for (i = 0; i < hose->region_count; i++) {
> >                 res = &hose->regions[i];
> >
> >                 if (((res->flags ^ flags) & PCI_REGION_TYPE) != 0)
> >                         continue;
> >
> > 		if (reg->flags & PCI_REGION_MEMORY)
> > 			continue;
> > ...
> >
> > any issues with this change?  If not I'll work up a proper patch.
> 
> Wolfgang, any comments on this?

I'm not much of a PCI expert.  If nobody else complains, feel free to
move on.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This is an unauthorized cybernetic announcement.


More information about the U-Boot mailing list