[U-Boot] fat.c:707: warning: array subscript is above array bounds

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081213222225.GN15295 at game.jcrosoft.org> you wrote:
>
> >  705         /* Terminate fs_type string. Writing past the end of vistart
> >  706            is ok - it's just the buffer. */
> >  707         vistart->fs_type[8] = '\0';
> 
> why not do something like this
> 
> 	*(vistart + sizeof(volume_info)) = '\0';

Because that would be terribly wrong - sizeof(volume_info)  is  >  23
(probably  24),  and  vistart  is a pointer volume_info, so you would
probably write some 500+ bytes beyond the end of the buffer.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
People seldom know what they want until you give them what  they  ask
for.