[U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

Wolfgang Denk wd at denx.de
Mon Dec 15 23:47:07 CET 2008


Dear Timur Tabi,

In message <1228325310-19275-1-git-send-email-timur at freescale.com> you wrote:
> All implementations of the functions i2c_reg_read() and i2c_reg_write() are
> identical.  We can save space and simplify the code by converting these
> functions into inlines and putting them in i2c.h.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> 
> v3: add 8xx-specific code, and include PRINTDs from blackfin and pxa
> 
> I'm posting this patch because I'm enhancing the I2C routines to support
> multiple I2C busses more easily, but I need to clean up the existing code
> first.
> 
> I'm going to be on vacation when the next merge window opens, so I'm posting
> this now in the hopes that it will be picked up when the window does open.

We've been discussing this long enough when the previous window was
open, so ...

>  cpu/arm920t/at91rm9200/i2c.c  |   14 ---------
>  cpu/arm926ejs/davinci/i2c.c   |   17 -----------
>  cpu/blackfin/i2c.c            |   16 ----------
>  cpu/mpc512x/i2c.c             |   17 -----------
>  cpu/mpc5xxx/i2c.c             |   16 ----------
>  cpu/mpc8220/i2c.c             |   16 ----------
>  cpu/mpc824x/drivers/i2c/i2c.c |   14 ---------
>  cpu/mpc8260/i2c.c             |   16 ----------
>  cpu/mpc8xx/i2c.c              |   33 ---------------------
>  cpu/ppc4xx/i2c.c              |   20 -------------
>  cpu/pxa/i2c.c                 |   15 ----------
>  drivers/i2c/fsl_i2c.c         |   16 ----------
>  drivers/i2c/soft_i2c.c        |   19 ------------
>  include/i2c.h                 |   62 +++++++++++++++++++++++++++++++++++++++-
>  14 files changed, 60 insertions(+), 231 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All these theories, diverse as they are, have two things  in  common:
they explain the observed facts, and they are completeley and utterly
wrong.                       - Terry Pratchett, _The Light Fantastic_


More information about the U-Boot mailing list