[U-Boot] [PATCH] IDE: Improving speed on reading data Part 1/1

[Wolfgang Denk]

Dear Stefan Althoefer,

In message <49384704.sPrSOzo/CYqyo4zk%stefan.althoefer at web.de> you wrote:
> [PATCH] IDE: Improving speed on reading data
> 
> This patch improves the speed when reading blocks from
> IDE devices by reading more than one block at a time. Up to
> 128 blocks are requested in one read command.
> 
> On my testplatform (Janz emPC-A400 with CompactFLASH card)
> this nearly doubled speed.
> 
> Also the ide_wait() code was rewritten to have lower latency
> by polling more frequently for status.

Can you please use git-format-patch to format the patch? I don't know
how you created the diff, but it looks strange to me (and harldy
readable).

> The patch is against "latest" u-boot git-repository
> 
> Please (still) be patient if style of submission or patches are
> offending.

Such comments must go below the "---" line

> Signed-off-by: Stefan Althoefer <stefan.althoefer at web.de>
> ----

Thsi is the place to add comments that are not supposed to become part
of the commit message.

> -		ide_outb (device, ATA_SECT_CNT, 1);
> +		scnt = (blkcnt > 128) ? 128 : blkcnt;
> +		ide_outb (device, ATA_SECT_CNT, scnt);

What happens if you try to read at or beyond the end of the device?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain off-line, please wait.