[U-Boot] [PATCH 1/2] cmd_i2c: rename EDO, DDR and SDRAM to avoid conflict with at91 memory setup

Wolfgang Denk wd at denx.de
Wed Dec 17 02:21:54 CET 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1229469026-7344-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> Cc: Timo Tuunainen <timo.tuunainen at sysart.fi>
> ---
>  common/cmd_i2c.c |   58 +++++++++++++++++++++++++++---------------------------
>  1 files changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index 448f2fe..a662b53 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -712,7 +712,7 @@ static void decode_bits (u_char const b, char const *str[], int const do_once)
>   */
>  int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  {
> -	enum { unknown, EDO, SDRAM, DDR2 } type;
> +	enum { unknown, _EDO, _SDRAM, _DDR2 } type;

Please do not use leading underscores in regular variable names. They
are reserved in C.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It must be remembered that there is nothing more difficult  to  plan,
more  doubtful  of  success,  nor  more dangerous to manage, than the
creation of a new system. For the initiator has the enmity of all who
would profit by the preservation of the old institutions  and  merely
lukewarm defenders in those who would gain by the new ones.
- Machiavelli


More information about the U-Boot mailing list