[U-Boot] [PATCH 1/2 V2] cmd_i2c: rename EDO, DDR and SDRAM to avoid conflict with at91 memory setup

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081217115717.GD26222 at game.jcrosoft.org> you wrote:
>
> > > -	enum { unknown, EDO, SDRAM, DDR2 } type;
> > > +	enum { unknown, edo, sdram, ddr2 } type;
> > 
> > Sorry again, but lower case enum labels violate the coding style
> > either:
> > 
> > 	Chapter 12: Macros, Enums and RTL
> > 
> > 	Names of macros defining constants and labels in enums are
> > 	capitalized.
> 	so could you tell what do you wish to have (an example)
> 	__DDR2?

I don't really care about the exact variable name as long as it's
standard conforming and does not violate the coding style.

__DDR2 would be obviuosly a very bad choice. Prefixing names with "_"
or "__" is used only to reserve name spaces - which is not waht you're
doing here.


Actually I don't understand at all why you want to change this file.
Using "DDR2" as a local variable name is perfectly valid.

If there are problems because some stupid  header  file  with  global
scope  #defines a "DDR2" name that include file needs fixing, but not
the C file here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A conservative is a man who believes that nothing should be done for
the first time.                                   - Alfred E. Wiggam