[U-Boot] [PATCH 1/2 V2] at91rm9200: rename lowlevel init value to CONFIG_SYS_

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:30 Wed 17 Dec     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20081217214818.GC10620 at game.jcrosoft.org> you wrote:
> >
> > > > +#define CONFIG_SYS_SDRC_MR_VAL2 0x00000003 /* Load Mode Register */
> > > > +#define CONFIG_SYS_SDRC_MR_VAL3 0x00000000 /* Normal Mode */
> > > >  #define SDRC_TR 0xFFFFFF94
> > > > -#define SDRC_TR_VAL 0x000002E0 /* Write refresh rate */
> > > > +#define CONFIG_SYS_SDRC_TR_VAL 0x000002E0 /* Write refresh rate */
> > > 
> > > I think it is fundamentally wrong to put these #defines in the board's
> > > memsetup.S file. The do not belong into some source file, but into the
> > > board config file, include/configs/<name>
> > > 
> > > If we touch this part, should we not do it right, then?
> > It's done in the second patch
> 
> Not really.
> 
> Your patch leaves #defines like MC_PUIA, MC_PUP, MC_PUER, MC_ASR,
> MC_AASR, ... untouched. These shouldbe fixed, too.
> 
> And your patch fixes only this board. We  have  the  same  cruft  for
> example in cpu/arm920t/at91rm9200/lowlevel_init.S

the register cleanup will be done in a third path (the lowlevel_init.S)

Best Regards,
J.