[U-Boot] [RFC] nand boot for 85xx

[Kumar Gala]

On Dec 18, 2008, at 12:20 AM, Dave Liu wrote:

> ---
> The patch is to be done, It is only giving the context
> why move the definition of fsl_law from .c to .h.
>
> Makefile                                      |   13 +-
> board/freescale/mpc8572ds/config.mk           |    5 +
> board/freescale/mpc8572ds/nand_boot.c         |   75 ++++
> board/freescale/mpc8572ds/u-boot-nand.lds     |  140 ++++++++
> cpu/mpc85xx/nand_init.c                       |  102 ++++++
> cpu/mpc85xx/nand_start.S                      |  469 ++++++++++++++++ 
> +++++++++
> cpu/mpc85xx/start.S                           |    3 +
> drivers/misc/fsl_law.c                        |    9 +-
> include/asm-ppc/fsl_law.h                     |    2 +
> include/configs/MPC8572DS.h                   |   64 ++++-
> nand_spl/board/freescale/mpc8572ds/Makefile   |  110 ++++++
> nand_spl/board/freescale/mpc8572ds/u-boot.lds |   56 +++
> 12 files changed, 1040 insertions(+), 8 deletions(-)
> create mode 100644 board/freescale/mpc8572ds/nand_boot.c
> create mode 100644 board/freescale/mpc8572ds/u-boot-nand.lds
> create mode 100644 cpu/mpc85xx/nand_init.c
> create mode 100644 cpu/mpc85xx/nand_start.S
> create mode 100644 nand_spl/board/freescale/mpc8572ds/Makefile
> create mode 100644 nand_spl/board/freescale/mpc8572ds/u-boot.lds

While I know Dave is posting this patch for my query on law changes I  
do have some comments now that I understand it better.

1. patch should be split into at least two patches.  One for the first  
stage loader changes and one for the second stage u-boot
2. we should look at refactoring common code so not to duplicate it.   
For example can we put a fair amount of common code w/start.S in a  
header to share w/nand_start.S

Also, how much space do we have for the first stage loader?  How big  
is the current u-boot created first stage loader (how much free space  
do we have?)?

- k