[U-Boot] [RFC][PATCH] Code Clean-up (weak functions)

Graeme Russ graeme.russ at gmail.com
Mon Dec 22 10:16:33 CET 2008


Mike,

On Mon, Dec 22, 2008 at 8:05 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Saturday 13 December 2008 00:26:26 Graeme Russ wrote:
>> This patch makes all definitions, declarations and usages of weak functions
>> consistent.
>
> a quick glance shows that it breaks things (the ELF and Blackfin stuff
> certainly appears to be wrong).  i'm guessing you focused on style for the RFC
> part rather than the result actually being correct ...
> -mike
>

Thanks for having a look at this. Would it be possible for you to be a bit more
specific about 'wrong' if for nothing other that me gaining a better
understanding of how it works, and how it breaks

I was, honestly, hoping that the changes would not break things.

Thanks,


Graeme


More information about the U-Boot mailing list