[U-Boot] [PATCH] make make quiet
Wolfgang Denk
wd at denx.de
Tue Dec 30 23:14:06 CET 2008
Dear kenneth johansson,
In message <1230636057.17914.5.camel at duo> you wrote:
>
> Only print out the target name during make.
> For old style set V=1
What is the rationale for this patch? I can see no real advantage with
it.
If you find the make output annoying, you can silence make by passing
the "-s" flag.
On the other hand, your patch braks building with "-s" - I get:
$ make -s all
grep: writing output: Broken pipe
a - ppc_longjmp.o
a - ppc_setjmp.o
a - stubs.o
a - bzlib.o
a - bzlib_crctable.o
a - bzlib_decompress.o
a - bzlib_randtable.o
a - bzlib_huffman.o
a - crc16.o
a - crc32.o
a - ctype.o
a - display_options.o
a - div64.o
a - gunzip.o
a - lmb.o
a - ldiv.o
a - sha1.o
a - string.o
a - strmhz.o
a - vsprintf.o
a - zlib.o
a - io.o
a - firmware_sc_task_bestcomm.impl.o
a - firmware_sc_task.impl.o
a - i2c.o
a - traps.o
a - cpu.o
a - cpu_init.o
a - ide.o
a - interrupts.o
a - loadtask.o
a - pci_mpc5200.o
...
etc.
Even without "-s" there are some errors for example when I try to
build the "TQM5200" configuration.
But most of all, your patch costs a lot of additional processes.
Running "make all" for above configuration takes 2150 processes
without your patch, and 2410 with it. And this does not even count
the additional calls to shell builtins.
Unless you have a really good reason why this patch should be
applied, I tend to reject it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Virtual" means never knowing where your next byte is coming from.
More information about the U-Boot
mailing list