[U-Boot] [PATCH 0/5] Command usage cleanup

Peter Tyser ptyser at xes-inc.com
Wed Dec 31 19:07:59 CET 2008


This patch series attempts to clean up how the "usage" field
of the cmd_tbl_s structure is used.  It does 3 things:
1. Adds a cmd_usage() function to print a command's usage
2. Removes the command name from the usage field for all commands
3. Removes newlines from the usage field of all commands

The benefits of these changes are:
1. Command formatting in the "help" command output will always
   be properly aligned. A fair number of commands currently
   aren't properly formated, eg
   "cmd1 - description" vs "cmd2    - description".
2. Command definitions are reduced in size/complexity. The patch
   shaved off 1.1KB from the XPedite5370 image for example.

Most of the changes were done via scripts, so let me know if
anything looks fishy.

Best,
Peter

Peter Tyser (5):
  Clean up diufb command definitions
  pcs440ep: Clean up led command definition
  Standardize command usage messages with new cmd_usage() function
  amcc: Clean up command usage output
  Command usage cleanup

 README                                        |    3 +
 board/BuS/EB+MCF-EV123/EB+MCF-EV123.c         |    4 +-
 board/MAI/AmigaOneG3SE/cmd_boota.c            |    2 +-
 board/MAI/menu/cmd_menu.c                     |    2 +-
 board/ads5121/ads5121_diu.c                   |    4 +-
 board/amcc/acadia/cmd_acadia.c                |    4 +-
 board/amcc/canyonlands/bootstrap.c            |    4 +-
 board/amcc/katmai/cmd_katmai.c                |    4 +-
 board/amcc/kilauea/cmd_pll.c                  |    8 ++--
 board/amcc/luan/luan.c                        |    4 +-
 board/amcc/makalu/cmd_pll.c                   |    8 ++--
 board/amcc/sequoia/cmd_sequoia.c              |    4 +-
 board/amcc/taihu/lcd.c                        |   14 +++---
 board/amcc/taihu/taihu.c                      |   10 ++--
 board/amcc/taihu/update.c                     |    2 +-
 board/amcc/taishan/lcd.c                      |   20 +++++-----
 board/amcc/taishan/showinfo.c                 |    6 +-
 board/amcc/taishan/update.c                   |    2 +-
 board/amcc/yucca/cmd_yucca.c                  |    4 +-
 board/amirix/ap1000/ap1000.c                  |   10 ++--
 board/amirix/ap1000/powerspan.c               |    2 +-
 board/barco/barco.c                           |    8 ++--
 board/bc3450/cmd_bc3450.c                     |   10 ++--
 board/bf537-stamp/cmd_bf537led.c              |    2 +-
 board/cm5200/cmd_cm5200.c                     |    2 +-
 board/delta/delta.c                           |    2 +-
 board/esd/ar405/ar405.c                       |    6 +-
 board/esd/cms700/cms700.c                     |    2 +-
 board/esd/common/auto_update.c                |    2 +-
 board/esd/common/cmd_loadpci.c                |    2 +-
 board/esd/common/lcd.c                        |    4 +-
 board/esd/common/xilinx_jtag/micro.c          |    2 +-
 board/esd/cpci2dp/cpci2dp.c                   |    2 +-
 board/esd/cpci405/cpci405.c                   |    6 +-
 board/esd/cpci5200/cpci5200.c                 |    2 +-
 board/esd/cpci750/cpci750.c                   |    2 +-
 board/esd/dasa_sim/cmd_dasa_sim.c             |    4 +-
 board/esd/du440/du440.c                       |   16 ++++----
 board/esd/hh405/hh405.c                       |    2 +-
 board/esd/ocrtc/cmd_ocrtc.c                   |    4 +-
 board/esd/pci405/cmd_pci405.c                 |    2 +-
 board/esd/pci405/pci405.c                     |    2 +-
 board/esd/pf5200/pf5200.c                     |    6 +-
 board/esd/plu405/plu405.c                     |    2 +-
 board/esd/pmc405/pmc405.c                     |    2 +-
 board/esd/pmc440/cmd_pmc440.c                 |   18 ++++----
 board/esd/tasreg/tasreg.c                     |   12 +++---
 board/esd/voh405/voh405.c                     |    2 +-
 board/evb64260/zuma_pbb.c                     |    6 +-
 board/freescale/common/pixis.c                |    4 +-
 board/freescale/common/sys_eeprom.c           |    4 +-
 board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c |    4 +-
 board/g2000/g2000.c                           |    6 +-
 board/hymod/bsp.c                             |    8 ++--
 board/keymile/common/keymile_hdlc_enet.c      |    4 +-
 board/lwmon/lwmon.c                           |   10 ++--
 board/lwmon5/kbd.c                            |    2 +-
 board/lwmon5/lwmon5.c                         |    6 +-
 board/mpl/common/common_util.c                |    2 +-
 board/mpl/mip405/cmd_mip405.c                 |    2 +-
 board/mpl/pati/cmd_pati.c                     |    2 +-
 board/mpl/pip405/cmd_pip405.c                 |    2 +-
 board/mpl/vcma9/cmd_vcma9.c                   |    2 +-
 board/pcippc2/pcippc2.c                       |    4 +-
 board/pcs440ep/pcs440ep.c                     |    6 +-
 board/pn62/cmd_pn62.c                         |    8 ++--
 board/prodrive/pdnb3/pdnb3.c                  |    4 +-
 board/pxa255_idp/pxa_idp.c                    |    2 +-
 board/r360mpi/r360mpi.c                       |    2 +-
 board/renesas/sh7785lcr/rtl8169_mac.c         |    8 ++--
 board/renesas/sh7785lcr/selfcheck.c           |    6 +-
 board/sandburst/common/ppc440gx_i2c.c         |    2 +-
 board/sandburst/karef/karef.c                 |    4 +-
 board/sandburst/metrobox/metrobox.c           |    4 +-
 board/siemens/common/fpga.c                   |    4 +-
 board/siemens/pcu_e/pcu_e.c                   |    4 +-
 board/ssv/common/cmd_sled.c                   |    4 +-
 board/ssv/common/wd_pio.c                     |    4 +-
 board/tqc/tqm5200/cmd_stk52xx.c               |   22 +++++-----
 board/tqc/tqm5200/cmd_tb5200.c                |    4 +-
 board/tqc/tqm8272/tqm8272.c                   |    2 +-
 board/trab/cmd_trab.c                         |   24 +++++-----
 board/trab/trab.c                             |    2 +-
 board/trizepsiv/eeprom.c                      |   10 ++--
 board/w7o/cmd_vpd.c                           |    4 +-
 board/zeus/update.c                           |    2 +-
 board/zeus/zeus.c                             |    4 +-
 common/cmd_ambapp.c                           |    2 +-
 common/cmd_autoscript.c                       |    2 +-
 common/cmd_bdinfo.c                           |    2 +-
 common/cmd_bedbug.c                           |   20 +++++-----
 common/cmd_bmp.c                              |    6 +-
 common/cmd_boot.c                             |    6 +-
 common/cmd_bootldr.c                          |    2 +-
 common/cmd_bootm.c                            |   14 +++---
 common/cmd_cache.c                            |   12 +++---
 common/cmd_console.c                          |    2 +-
 common/cmd_cplbinfo.c                         |    2 +-
 common/cmd_date.c                             |    4 +-
 common/cmd_dcr.c                              |   16 ++++----
 common/cmd_df.c                               |    4 +-
 common/cmd_diag.c                             |    2 +-
 common/cmd_display.c                          |    2 +-
 common/cmd_doc.c                              |   14 +++---
 common/cmd_dtt.c                              |    2 +-
 common/cmd_eeprom.c                           |    6 +-
 common/cmd_elf.c                              |    4 +-
 common/cmd_ext2.c                             |    8 ++--
 common/cmd_fat.c                              |    6 +-
 common/cmd_fdc.c                              |    4 +-
 common/cmd_fdos.c                             |    6 +-
 common/cmd_fdt.c                              |   16 ++++----
 common/cmd_flash.c                            |   20 +++++-----
 common/cmd_fpga.c                             |    4 +-
 common/cmd_i2c.c                              |   42 ++++++++++----------
 common/cmd_ide.c                              |   14 +++---
 common/cmd_immap.c                            |   34 ++++++++--------
 common/cmd_irq.c                              |    4 +-
 common/cmd_itest.c                            |    4 +-
 common/cmd_jffs2.c                            |   12 +++---
 common/cmd_license.c                          |    2 +-
 common/cmd_load.c                             |   16 ++++----
 common/cmd_log.c                              |    6 +-
 common/cmd_mac.c                              |    2 +-
 common/cmd_mem.c                              |   54 ++++++++++++------------
 common/cmd_mfsl.c                             |   16 ++++----
 common/cmd_mii.c                              |    6 +-
 common/cmd_misc.c                             |    6 +-
 common/cmd_mmc.c                              |    2 +-
 common/cmd_mp.c                               |   10 ++--
 common/cmd_nand.c                             |   24 +++++-----
 common/cmd_net.c                              |   20 +++++-----
 common/cmd_nvedit.c                           |   16 ++++----
 common/cmd_onenand.c                          |    4 +-
 common/cmd_otp.c                              |    4 +-
 common/cmd_pci.c                              |    4 +-
 common/cmd_pcmcia.c                           |    2 +-
 common/cmd_portio.c                           |    8 ++--
 common/cmd_reginfo.c                          |    2 +-
 common/cmd_reiser.c                           |    8 ++--
 common/cmd_sata.c                             |   10 ++--
 common/cmd_scsi.c                             |   14 +++---
 common/cmd_setexpr.c                          |    4 +-
 common/cmd_sf.c                               |    4 +-
 common/cmd_spi.c                              |    2 +-
 common/cmd_strings.c                          |    4 +-
 common/cmd_terminal.c                         |    2 +-
 common/cmd_ubi.c                              |    6 +-
 common/cmd_universe.c                         |    2 +-
 common/cmd_usb.c                              |   10 ++--
 common/cmd_vfd.c                              |    4 +-
 common/cmd_ximg.c                             |    2 +-
 common/cmd_yaffs2.c                           |   24 +++++-----
 common/command.c                              |   24 +++++++----
 common/hush.c                                 |    4 +-
 common/kgdb.c                                 |    2 +-
 common/lcd.c                                  |    2 +-
 common/main.c                                 |    4 +-
 cpu/mpc512x/speed.c                           |    2 +-
 cpu/mpc8260/bedbug_603e.c                     |    4 +-
 cpu/mpc83xx/ecc.c                             |    6 +-
 cpu/mpc83xx/speed.c                           |    2 +-
 cpu/mpc8xx/bedbug_860.c                       |    4 +-
 cpu/nios2/sysid.c                             |    2 +-
 cpu/ppc4xx/bedbug_405.c                       |    4 +-
 drivers/gpio/pca953x.c                        |    4 +-
 drivers/misc/ds4510.c                         |    4 +-
 drivers/qe/qe.c                               |    6 +-
 include/command.h                             |    7 +++
 tools/updater/cmd_flash.c                     |   14 +++---
 170 files changed, 580 insertions(+), 564 deletions(-)



More information about the U-Boot mailing list