[U-Boot-Users] [PATCH] Enable the isdram command on the MPC8360EMDS board
Jerry Van Baren
gerald.vanbaren at ge.com
Mon Jan 14 22:08:51 CET 2008
Jon Loeliger wrote:
> On Sat, 2008-01-12 at 12:24, Jerry Van Baren wrote:
>
>> Hi Kim,
>>
>> The isdram command is controlled separately from the rest of the i2c
>> commands (CONFIG_CMD_I2C + CONFIG_CMD_SDRAM). I did this originally
>> because the isdram command was arguably a memory consuming luxury.
>> Luxuries tend to become necessities over time...
>>
>> Larry Johnson submitted a patch yesterday to extend the decoding and
>> printout to include DDR2 fields, making this even more useful (and jdl
>> is claiming a share of the credit ;-).
>>
>> gvb
>
> I'm not claiming any credit for it, but if I do the
> following command:
>
> $ git show d9b94f28a442b001 -- cpu/mpc85xx/spd_sdram.c
>
> Someone who impersonated me quite well appears to have
> checked in whole bunch of DDR2 decode stuff way back in
> July of 2005.
[snip]
> Weird, huh?
>
> jdl
Hi Jon,
I'm kinda loosing the thread here. I think we are talking about two
totally different decodes of the same data.
What I'm crediting Larry for isn't the decoding you are pointing to.
You did machine decoding to make the DDR2 _work,_ which is invaluable.
Larry did the decoding to improve the human-readable output of the
"isdram" command. This isn't invaluable in quite the same way, but
still is really nice to be able to dump the SPD and decode it into ASCII
for the poor developer. I don't know if your board(s) have
CONFIG_CMD_SDRAM defined (it is off by default) - doesn't look like it.
If not, turn it on and try it out.
Best regards,
gvb
More information about the U-Boot
mailing list