[U-Boot] [PATCH 01/13 v5] ARM: OMAP3: Add pin mux, clock and cpu headers

[Wolfgang Denk]

Dear dirk.behme at googlemail.com,

In message <490df2dc.1438560a.2e57.2697 at mx.google.com> you wrote:
> Subject: [PATCH 01/13 v5] ARM: OMAP3: Add pin mux, clock and cpu headers
> 
> From: Dirk Behme <dirk.behme at gmail.com>
> 
> Add pin mux, clock and cpu header files for OMAP3.
> 
> Signed-off-by: Dirk Behme <dirk.behme at gmail.com>
...

> Index: u-boot-main/include/asm-arm/arch-omap3/bits.h
> ===================================================================
> --- /dev/null
> +++ u-boot-main/include/asm-arm/arch-omap3/bits.h
> @@ -0,0 +1,48 @@
> +/* bits.h
> + * Copyright (c) 2004 Texas Instruments
> + *
> + * This package is free software;  you can redistribute it and/or
> + * modify it under the terms of the license found in the file
> + * named COPYING that should have accompanied this file.

Can you please change this and explicitely write "under the terms  of
the  GNU General Public License ..." as you did in the file above? No
file COPYING accompanied this patch (and even if it did, an explicit
statement is always much better).

Note: this applies to all files in this and the following patches.


> + * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR
> + * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
> + * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
> + */
> +#ifndef __bits_h
> +#define __bits_h 1
> +
> +#define BIT0	(1 << 0)
> +#define BIT1	(1 << 1)
> +#define BIT2	(1 << 2)
> +#define BIT3	(1 << 3)
> +#define BIT4	(1 << 4)
> +#define BIT5	(1 << 5)
> +#define BIT6	(1 << 6)
> +#define BIT7	(1 << 7)
> +#define BIT8	(1 << 8)
> +#define BIT9	(1 << 9)
> +#define BIT10	(1 << 10)
> +#define BIT11	(1 << 11)
> +#define BIT12	(1 << 12)
> +#define BIT13	(1 << 13)
> +#define BIT14	(1 << 14)
> +#define BIT15	(1 << 15)
> +#define BIT16	(1 << 16)
> +#define BIT17	(1 << 17)
> +#define BIT18	(1 << 18)
> +#define BIT19	(1 << 19)
> +#define BIT20	(1 << 20)
> +#define BIT21	(1 << 21)
> +#define BIT22	(1 << 22)
> +#define BIT23	(1 << 23)
> +#define BIT24	(1 << 24)
> +#define BIT25	(1 << 25)
> +#define BIT26	(1 << 26)
> +#define BIT27	(1 << 27)
> +#define BIT28	(1 << 28)
> +#define BIT29	(1 << 29)
> +#define BIT30	(1 << 30)
> +#define BIT31	(1 << 31)
> +
> +#endif

And can we please get rid of this file alltogether? "Clever"  defini-
tions  like  these  just  make  the code harder to read and harder to
understand.  Thanks.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The net result is a system that is not only binary  compatible  with
4.3  BSD, but is even bug for bug compatible in almost all features."
- Avadit  Tevanian,  Jr.,  "Architecture-Independent  Virtual  Memory
Management  for  Parallel  and  Distributed  Environments:  The  Mach
Approach"