[U-Boot] [PATCH] bootvx: Cleanup & improvements

[Wolfgang Denk]

Dear Niklaus Giger,

In message <genhn6$6su$1 at ger.gmane.org> you wrote:
>
> >> The following improvements are made:
> >> - document bootvx in README
> >> - fix size too small by one in sprintf
> >> - changed old (pre 2004) device name ibmEmac to emac
> >> - boot device may be overriden in board config
> >> - servername may be defined in board config
> >> - additional parameters may be defined in board config
> >> - fixed some line wrappings
> >> - changed netstal-common.h to use the new settings
> > Could you split your patch a smallest changeset?
> How many changeset do you want? Is it sufficient to make two by just isolating the changes in netstal-common.h?

Please see http://www.denx.de/wiki/U-Boot/Patches:

	Changes that contain different, unrelated modifications shall
	be submitted as separate patches, one patch per changeset. 

> >> +#ifndef CONFIG_SYS_VXWORKS_BOOT_DEVICE
> >>  #if defined(CONFIG_4xx)
> >> -		sprintf (build_buf, "ibmEmac(0,0)");
> >> +#define		CONFIG_SYS_VXWORKS_BOOT_DEVICE "emac(0,0)"
> >> +#elif defined(CONFIG_IOP480)
> >> +#define		CONFIG_SYS_VXWORKS_BOOT_DEVICE "dc(0,0)"
> >> +#else
> >> +#define		CONFIG_SYS_VXWORKS_BOOT_DEVICE "eth(0,0)"
> >> +#endif
> >> +#endif
> > could we move thie define to an header?
> Which header shall I use? Is common.h right?

For VxWorks boot device names? Not really. vxworks.h ?

> Mmm. Looking at common.h I found that there max is defined with the same meaning as in cmd_elf.h. Probably worth a fix too.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe contains any amount of horrible ways  to  be  woken  up,
such as the noise of the mob breaking down the front door, the scream
of fire engines, or the realization that today is the Monday which on
Friday night was a comfortably long way off.
                                 - Terry Pratchett, _Moving Pictures_