[U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Tue Nov 18 10:34:37 CET 2008


On 09:55 Tue 18 Nov     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1226968111-965-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> > boot_relocate_fdt can only be used on PPC, M68K and SPARC
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  common/cmd_bootm.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> > index a8f85e9..22e8b30 100644
> > --- a/common/cmd_bootm.c
> > +++ b/common/cmd_bootm.c
> > @@ -499,6 +499,7 @@ int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> >  			break;
> >  #endif
> >  #ifdef CONFIG_OF_LIBFDT
> > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> 
> This change seems wrong to me. There are PPC systems which do not use
> the device tree - why should we enable this code for these?
thats already the case by the ifdef CONFIG_OF_LIBFDT

Best Regards,
J.


More information about the U-Boot mailing list